about summary refs log tree commit diff
path: root/src
diff options
context:
space:
mode:
authorEric Bailey <git@esb.lol>2024-06-18 18:46:34 -0500
committerGitHub <noreply@github.com>2024-06-19 02:46:34 +0300
commit5159495274934256038b3bd04d01e614a1ee064b (patch)
tree688eaf773955b3bccb933bb4e72e61a53db38e01 /src
parent07c2be255f42c60401cec1476e3347bdb0b28db5 (diff)
downloadvoidsky-5159495274934256038b3bd04d01e614a1ee064b.tar.zst
Move onboarding start to after successfull account creation (#4381)
* Move onboarding start to after successfull account creation

* Remove unused dispatch
Diffstat (limited to 'src')
-rw-r--r--src/screens/Signup/state.ts7
1 files changed, 5 insertions, 2 deletions
diff --git a/src/screens/Signup/state.ts b/src/screens/Signup/state.ts
index facc680bd..87700cb88 100644
--- a/src/screens/Signup/state.ts
+++ b/src/screens/Signup/state.ts
@@ -252,7 +252,6 @@ export function useSubmitSignup({
       dispatch({type: 'setIsLoading', value: true})
 
       try {
-        onboardingDispatch({type: 'start'}) // start now to avoid flashing the wrong view
         await createAccount({
           service: state.serviceUrl,
           email: state.email,
@@ -262,8 +261,12 @@ export function useSubmitSignup({
           inviteCode: state.inviteCode.trim(),
           verificationCode: verificationCode,
         })
+        /*
+         * Must happen last so that if the user has multiple tabs open and
+         * createAccount fails, one tab is not stuck in onboarding — Eric
+         */
+        onboardingDispatch({type: 'start'})
       } catch (e: any) {
-        onboardingDispatch({type: 'skip'}) // undo starting the onboard
         let errMsg = e.toString()
         if (e instanceof ComAtprotoServerCreateAccount.InvalidInviteCodeError) {
           dispatch({