diff options
author | dan <dan.abramov@gmail.com> | 2024-07-04 20:07:42 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-07-04 20:07:42 +0100 |
commit | 12bf79629370b59eaf3a8f052fef60bcf745fcf2 (patch) | |
tree | fccb629823e9f5bd8dccdf91323377aa2641e3b4 /src | |
parent | 4f02da96c8c2483923fdf52d1ee7cd8f34b15fba (diff) | |
download | voidsky-12bf79629370b59eaf3a8f052fef60bcf745fcf2.tar.zst |
Fix feed feedback (#4730)
Diffstat (limited to 'src')
-rw-r--r-- | src/state/feed-feedback.tsx | 12 | ||||
-rw-r--r-- | src/view/com/posts/Feed.tsx | 8 |
2 files changed, 13 insertions, 7 deletions
diff --git a/src/state/feed-feedback.tsx b/src/state/feed-feedback.tsx index 88f50daca..0a6c1d585 100644 --- a/src/state/feed-feedback.tsx +++ b/src/state/feed-feedback.tsx @@ -6,11 +6,8 @@ import throttle from 'lodash.throttle' import {PROD_DEFAULT_FEED} from '#/lib/constants' import {logEvent} from '#/lib/statsig/statsig' import {logger} from '#/logger' -import { - FeedDescriptor, - FeedPostSliceItem, - isFeedPostSlice, -} from '#/state/queries/post-feed' +import {FeedDescriptor, FeedPostSliceItem} from '#/state/queries/post-feed' +import {getFeedPostSlice} from '#/view/com/posts/Feed' import {useAgent} from './session' type StateContext = { @@ -93,11 +90,12 @@ export function useFeedFeedback(feed: FeedDescriptor, hasSession: boolean) { }, [enabled, sendToFeed]) const onItemSeen = React.useCallback( - (slice: any) => { + (feedItem: any) => { if (!enabled) { return } - if (!isFeedPostSlice(slice)) { + const slice = getFeedPostSlice(feedItem) + if (slice === null) { return } for (const postItem of slice.items) { diff --git a/src/view/com/posts/Feed.tsx b/src/view/com/posts/Feed.tsx index e6ad35610..27f75b41a 100644 --- a/src/view/com/posts/Feed.tsx +++ b/src/view/com/posts/Feed.tsx @@ -156,6 +156,14 @@ const interstials: Record< ], } +export function getFeedPostSlice(feedItem: FeedItem): FeedPostSlice | null { + if (feedItem.type === 'slice') { + return feedItem.slice + } else { + return null + } +} + // DISABLED need to check if this is causing random feed refreshes -prf // const REFRESH_AFTER = STALE.HOURS.ONE const CHECK_LATEST_AFTER = STALE.SECONDS.THIRTY |