diff options
| author | Eric Bailey <git@esb.lol> | 2024-09-15 15:42:45 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-09-15 15:42:45 -0500 |
| commit | 0681727b645161d479d63ab75907aedab42b245f (patch) | |
| tree | b436771c8dee81ca540de17f008723d6fe4f188d /src | |
| parent | 42b28fec9dc52c096d2073721a06828142a4a75e (diff) | |
| download | voidsky-0681727b645161d479d63ab75907aedab42b245f.tar.zst | |
Remove overflow hidden from external link outer el (#5356)
* Remove overflow hidden * Borders when no thumb * Fix overflow, add bg to no-thumb state * Cleanup
Diffstat (limited to 'src')
| -rw-r--r-- | src/view/com/util/post-embeds/ExternalLinkEmbed.tsx | 2 | ||||
| -rw-r--r-- | src/view/com/util/post-embeds/ExternalPlayerEmbed.tsx | 34 |
2 files changed, 33 insertions, 3 deletions
diff --git a/src/view/com/util/post-embeds/ExternalLinkEmbed.tsx b/src/view/com/util/post-embeds/ExternalLinkEmbed.tsx index 0bd65de8b..e6ab86f9c 100644 --- a/src/view/com/util/post-embeds/ExternalLinkEmbed.tsx +++ b/src/view/com/util/post-embeds/ExternalLinkEmbed.tsx @@ -59,7 +59,7 @@ export const ExternalLinkEmbed = ({ } return ( - <View style={[a.flex_col, a.rounded_sm, a.overflow_hidden]}> + <View style={[a.flex_col, a.rounded_sm]}> <LinkWrapper link={link} onOpen={onOpen} style={style}> {imageUri && !embedPlayerParams ? ( <View> diff --git a/src/view/com/util/post-embeds/ExternalPlayerEmbed.tsx b/src/view/com/util/post-embeds/ExternalPlayerEmbed.tsx index a1e509ef4..64ea0029f 100644 --- a/src/view/com/util/post-embeds/ExternalPlayerEmbed.tsx +++ b/src/view/com/util/post-embeds/ExternalPlayerEmbed.tsx @@ -227,8 +227,16 @@ export function ExternalPlayer({ <Animated.View ref={viewRef} collapsable={false} - style={[aspect, a.rounded_sm]}> - {link.thumb && (!isPlayerActive || isLoading) && ( + style={[ + aspect, + a.rounded_sm, + a.overflow_hidden, + { + borderBottomLeftRadius: 0, + borderBottomRightRadius: 0, + }, + ]}> + {link.thumb && (!isPlayerActive || isLoading) ? ( <> <Image style={[a.flex_1, styles.topRadius]} @@ -256,7 +264,29 @@ export function ExternalPlayer({ ]} /> </> + ) : ( + <Fill + style={[ + a.rounded_sm, + { + backgroundColor: + t.name === 'light' ? t.palette.contrast_975 : 'black', + borderBottomLeftRadius: 0, + borderBottomRightRadius: 0, + opacity: 0.3, + }, + ]} + /> )} + <MediaInsetBorder + opaque + style={[ + { + borderBottomLeftRadius: 0, + borderBottomRightRadius: 0, + }, + ]} + /> <PlaceholderOverlay isLoading={isLoading} isPlayerActive={isPlayerActive} |