diff options
author | dan <dan.abramov@gmail.com> | 2024-04-28 22:37:00 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-04-28 22:37:00 +0100 |
commit | 361d255e954d6afbc0bbae293acf73ac8882f356 (patch) | |
tree | e1d67d5c8ad543a8ebcfda8a22adf469da48fbea /src/view | |
parent | 256bb33de0cd24b0ac541bfdddc8daa55bf59b60 (diff) | |
download | voidsky-361d255e954d6afbc0bbae293acf73ac8882f356.tar.zst |
Remove useEffect from TimeElapsed (#3741)
Diffstat (limited to 'src/view')
-rw-r--r-- | src/view/com/util/TimeElapsed.tsx | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/view/com/util/TimeElapsed.tsx b/src/view/com/util/TimeElapsed.tsx index 6ea41b82b..02b0f2314 100644 --- a/src/view/com/util/TimeElapsed.tsx +++ b/src/view/com/util/TimeElapsed.tsx @@ -3,8 +3,6 @@ import React from 'react' import {useTickEveryMinute} from '#/state/shell' import {ago} from 'lib/strings/time' -// FIXME(dan): Figure out why the false positives - export function TimeElapsed({ timestamp, children, @@ -15,9 +13,11 @@ export function TimeElapsed({ const tick = useTickEveryMinute() const [timeElapsed, setTimeAgo] = React.useState(() => ago(timestamp)) - React.useEffect(() => { + const [prevTick, setPrevTick] = React.useState(tick) + if (prevTick !== tick) { + setPrevTick(tick) setTimeAgo(ago(timestamp)) - }, [timestamp, setTimeAgo, tick]) + } return children({timeElapsed}) } |