about summary refs log tree commit diff
path: root/src/view
diff options
context:
space:
mode:
authordan <dan.abramov@gmail.com>2024-02-28 01:35:25 +0000
committerGitHub <noreply@github.com>2024-02-27 17:35:25 -0800
commit2d14d0e2dbe845edb5836199ce79928395c079a0 (patch)
treed3549937a1bb809c721632e6f1ca3d7a50a852be /src/view
parent603f3c0be972e013900264d706e2d28b87a93122 (diff)
downloadvoidsky-2d14d0e2dbe845edb5836199ce79928395c079a0.tar.zst
Remove dangerous derived state from RichText (#3007)
* Remove facet resolution from RichText

* Remove derived state
Diffstat (limited to 'src/view')
-rw-r--r--src/view/screens/Storybook/Typography.tsx6
1 files changed, 4 insertions, 2 deletions
diff --git a/src/view/screens/Storybook/Typography.tsx b/src/view/screens/Storybook/Typography.tsx
index 8ee4270b2..f0d67c528 100644
--- a/src/view/screens/Storybook/Typography.tsx
+++ b/src/view/screens/Storybook/Typography.tsx
@@ -22,12 +22,14 @@ export function Typography() {
       <Text style={[a.text_2xs]}>atoms.text_2xs</Text>
 
       <RichText
-        resolveFacets
+        // TODO: This only supports already resolved facets.
+        // Resolving them on read is bad anyway.
         value={`This is rich text. It can have mentions like @bsky.app or links like https://bsky.social`}
       />
       <RichText
         selectable
-        resolveFacets
+        // TODO: This only supports already resolved facets.
+        // Resolving them on read is bad anyway.
         value={`This is rich text. It can have mentions like @bsky.app or links like https://bsky.social`}
         style={[a.text_xl]}
       />