diff options
author | Paul Frazee <pfrazee@gmail.com> | 2023-12-09 15:09:31 -0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-12-09 15:09:31 -0800 |
commit | 6b3eb401b04ee442005a9690dcf90e16d46c35e0 (patch) | |
tree | 536ed44b8b7f436e4144573dedef8d41c7cb3801 /src/view/shell/desktop/LeftNav.tsx | |
parent | d854e882187c4358ae3b4c1fb9d1324f5fe215e4 (diff) | |
download | voidsky-6b3eb401b04ee442005a9690dcf90e16d46c35e0.tar.zst |
Multiple notifications fixes (#2154)
* Dont reset notifications feed on push notification event * Dont separate notifications by read state to avoid jank * On notifications screen focus, check latest and only rerender if not scrolled down * Reuse the cached notifs page when its not stale * Bump ios build number * Improve comments * Change the 'mark all read' condition to avoid firing too early
Diffstat (limited to 'src/view/shell/desktop/LeftNav.tsx')
-rw-r--r-- | src/view/shell/desktop/LeftNav.tsx | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/src/view/shell/desktop/LeftNav.tsx b/src/view/shell/desktop/LeftNav.tsx index 2ed294501..e294431f3 100644 --- a/src/view/shell/desktop/LeftNav.tsx +++ b/src/view/shell/desktop/LeftNav.tsx @@ -45,10 +45,7 @@ import {useUnreadNotifications} from '#/state/queries/notifications/unread' import {useComposerControls} from '#/state/shell/composer' import {useFetchHandle} from '#/state/queries/handle' import {emitSoftReset} from '#/state/events' -import {useQueryClient} from '@tanstack/react-query' -import {RQKEY as NOTIFS_RQKEY} from '#/state/queries/notifications/feed' import {NavSignupCard} from '#/view/shell/NavSignupCard' -import {truncateAndInvalidate} from '#/state/queries/util' function ProfileCard() { const {currentAccount} = useSession() @@ -123,7 +120,6 @@ interface NavItemProps { } function NavItem({count, href, icon, iconFilled, label}: NavItemProps) { const pal = usePalette('default') - const queryClient = useQueryClient() const {currentAccount} = useSession() const {isDesktop, isTablet} = useWebMediaQueries() const [pathName] = React.useMemo(() => router.matchPath(href), [href]) @@ -149,14 +145,10 @@ function NavItem({count, href, icon, iconFilled, label}: NavItemProps) { if (isCurrent) { emitSoftReset() } else { - if (href === '/notifications') { - // fetch new notifs on view - truncateAndInvalidate(queryClient, NOTIFS_RQKEY()) - } onPress() } }, - [onPress, isCurrent, queryClient, href], + [onPress, isCurrent], ) return ( |