about summary refs log tree commit diff
path: root/src/view/screens/SavedFeeds.tsx
diff options
context:
space:
mode:
authorEric Bailey <git@esb.lol>2023-11-28 12:50:41 -0600
committerGitHub <noreply@github.com>2023-11-28 12:50:41 -0600
commitbb9d340d42420005cf4b0a6aa1ff5be4e0ef6bfa (patch)
tree26220f706431d742983de2a5fc547ba72227f907 /src/view/screens/SavedFeeds.tsx
parent0b2c85b967ea7a2dd18261773449260b80004423 (diff)
downloadvoidsky-bb9d340d42420005cf4b0a6aa1ff5be4e0ef6bfa.tar.zst
Fix pinned feeds mutation issue (#2016)
Diffstat (limited to 'src/view/screens/SavedFeeds.tsx')
-rw-r--r--src/view/screens/SavedFeeds.tsx6
1 files changed, 4 insertions, 2 deletions
diff --git a/src/view/screens/SavedFeeds.tsx b/src/view/screens/SavedFeeds.tsx
index 640d76a5c..ce668877b 100644
--- a/src/view/screens/SavedFeeds.tsx
+++ b/src/view/screens/SavedFeeds.tsx
@@ -185,7 +185,8 @@ function ListItem({
       queryClient.getQueryData<UsePreferencesQueryResponse>(
         preferencesQueryKey,
       )?.feeds
-    const pinned = feeds?.pinned ?? []
+    // create new array, do not mutate
+    const pinned = feeds?.pinned ? [...feeds.pinned] : []
     const index = pinned.indexOf(feedUri)
 
     if (index === -1 || index === 0) return
@@ -210,7 +211,8 @@ function ListItem({
       queryClient.getQueryData<UsePreferencesQueryResponse>(
         preferencesQueryKey,
       )?.feeds
-    const pinned = feeds?.pinned ?? []
+    // create new array, do not mutate
+    const pinned = feeds?.pinned ? [...feeds.pinned] : []
     const index = pinned.indexOf(feedUri)
 
     if (index === -1 || index >= pinned.length - 1) return