diff options
| author | Ollie Hsieh <renahlee@outlook.com> | 2023-04-17 15:41:44 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-04-17 15:41:44 -0700 |
| commit | 2509290fdd2b20c76c302d4962216f5d2d2b5a73 (patch) | |
| tree | 455bdd7420556e80242ad245ba8d9907ec6c84ee /src/view/com/util/UserBanner.tsx | |
| parent | 91fadadb5848404bc47b69879bbc38a9011a0c62 (diff) | |
| download | voidsky-2509290fdd2b20c76c302d4962216f5d2d2b5a73.tar.zst | |
Split image cropping into secondary step (#473)
* Split image cropping into secondary step * Use ImageModel and GalleryModel * Add fix for pasting image URLs * Move models to state folder * Fix things that broke after rebase * Latest -- has image display bug * Remove contentFit * Fix iOS display in gallery * Tuneup the api signatures and implement compress/resize on web * Fix await * Lint fix and remove unused function * Fix android image pathing * Fix external embed x button on android * Remove min-height from composer (no longer useful and was mispositioning the composer on android) * Fix e2e picker --------- Co-authored-by: Paul Frazee <pfrazee@gmail.com>
Diffstat (limited to 'src/view/com/util/UserBanner.tsx')
| -rw-r--r-- | src/view/com/util/UserBanner.tsx | 15 |
1 files changed, 4 insertions, 11 deletions
diff --git a/src/view/com/util/UserBanner.tsx b/src/view/com/util/UserBanner.tsx index d54b41506..40c82eaf2 100644 --- a/src/view/com/util/UserBanner.tsx +++ b/src/view/com/util/UserBanner.tsx @@ -4,12 +4,8 @@ import {FontAwesomeIcon} from '@fortawesome/react-native-fontawesome' import {IconProp} from '@fortawesome/fontawesome-svg-core' import {Image} from 'expo-image' import {colors} from 'lib/styles' -import { - openCamera, - openCropper, - openPicker, - PickedMedia, -} from '../../../lib/media/picker' +import {openCamera, openCropper, openPicker} from '../../../lib/media/picker' +import {Image as TImage} from 'lib/media/types' import {useStores} from 'state/index' import { usePhotoLibraryPermission, @@ -24,7 +20,7 @@ export function UserBanner({ onSelectNewBanner, }: { banner?: string | null - onSelectNewBanner?: (img: PickedMedia | null) => void + onSelectNewBanner?: (img: TImage | null) => void }) { const store = useStores() const pal = usePalette('default') @@ -42,7 +38,6 @@ export function UserBanner({ } onSelectNewBanner?.( await openCamera(store, { - mediaType: 'photo', // compressImageMaxWidth: 3000, TODO needed? width: 3000, // compressImageMaxHeight: 1000, TODO needed? @@ -59,9 +54,7 @@ export function UserBanner({ if (!(await requestPhotoAccessIfNeeded())) { return } - const items = await openPicker(store, { - mediaType: 'photo', - }) + const items = await openPicker(store) onSelectNewBanner?.( await openCropper(store, { mediaType: 'photo', |