diff options
| author | dan <dan.abramov@gmail.com> | 2024-12-12 17:37:07 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-12-12 17:37:07 +0000 |
| commit | f8cdd6b9ae46a9a4efe0be87e55ee1debded4f91 (patch) | |
| tree | 87884914d17ca8d466bcb57a1a668f77a1d7338f /src/view/com/notifications/NotificationFeedItem.tsx | |
| parent | 10e241e7eb5a45a0c35802618f52b411dcecd0b0 (diff) | |
| download | voidsky-f8cdd6b9ae46a9a4efe0be87e55ee1debded4f91.tar.zst | |
[Notifications] Add a Mentions tab (#7044)
* Split out NotificationsTab * Remove unused route parameter * Refine the split between components * Hoist some logic out of NotificationFeed * Remove unused option * Add all|conversations to query, hardcode "all" * Add a Conversations tab * Rename to Mentions * Bump packages * Rename fields * Fix oopsie * Simplify header * Track active tab * Fix types * Separate logic for tabs * Better border for first unread * Highlight unread for all only * Fix spinner races * Fix fetchPage races * Fix bottom bar border being obscured by glimmer * Remember last tab within the session * One tab at a time * Fix TS * Handle all RQKEY usages * Nit
Diffstat (limited to 'src/view/com/notifications/NotificationFeedItem.tsx')
| -rw-r--r-- | src/view/com/notifications/NotificationFeedItem.tsx | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/src/view/com/notifications/NotificationFeedItem.tsx b/src/view/com/notifications/NotificationFeedItem.tsx index 4902e66bc..1267ce089 100644 --- a/src/view/com/notifications/NotificationFeedItem.tsx +++ b/src/view/com/notifications/NotificationFeedItem.tsx @@ -79,10 +79,12 @@ interface Author { let NotificationFeedItem = ({ item, moderationOpts, + highlightUnread, hideTopBorder, }: { item: FeedNotification moderationOpts: ModerationOpts + highlightUnread: boolean hideTopBorder?: boolean }): React.ReactNode => { const queryClient = useQueryClient() @@ -151,6 +153,7 @@ let NotificationFeedItem = ({ if (!item.subject) { return null } + const isHighlighted = highlightUnread && !item.notification.isRead return ( <Link testID={`feedItem-by-${item.notification.author.handle}`} @@ -160,12 +163,10 @@ let NotificationFeedItem = ({ <Post post={item.subject} style={ - item.notification.isRead - ? undefined - : { - backgroundColor: pal.colors.unreadNotifBg, - borderColor: pal.colors.unreadNotifBorder, - } + isHighlighted && { + backgroundColor: pal.colors.unreadNotifBg, + borderColor: pal.colors.unreadNotifBorder, + } } hideTopBorder={hideTopBorder} /> |