diff options
author | dan <dan.abramov@gmail.com> | 2023-11-21 22:42:30 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-11-21 22:42:30 +0000 |
commit | 4c4ba553bdc4029e78eaf2ccf0f9df12e41a1b01 (patch) | |
tree | e97890d72da1fd0a2c10cc501f530a04dae3157a /src/view/com/notifications/Feed.tsx | |
parent | f18b9b32b0d296c8d19dc06956699f95c0af9be2 (diff) | |
download | voidsky-4c4ba553bdc4029e78eaf2ccf0f9df12e41a1b01.tar.zst |
Shadow refactoring and improvements (#1959)
* Make shadow a type-only concept * Prevent unnecessary init state recalc * Use derived state instead of effects * Batch emitter updates * Use object first seen time instead of dataUpdatedAt * Stop threading dataUpdatedAt through * Use same value consistently
Diffstat (limited to 'src/view/com/notifications/Feed.tsx')
-rw-r--r-- | src/view/com/notifications/Feed.tsx | 11 |
1 files changed, 2 insertions, 9 deletions
diff --git a/src/view/com/notifications/Feed.tsx b/src/view/com/notifications/Feed.tsx index 2dac75e3c..ba88f78c0 100644 --- a/src/view/com/notifications/Feed.tsx +++ b/src/view/com/notifications/Feed.tsx @@ -38,7 +38,6 @@ export function Feed({ const {markAllRead} = useUnreadNotificationsApi() const { data, - dataUpdatedAt, isLoading, isFetching, isFetched, @@ -132,15 +131,9 @@ export function Feed({ } else if (item === LOADING_ITEM) { return <NotificationFeedLoadingPlaceholder /> } - return ( - <FeedItem - item={item} - dataUpdatedAt={dataUpdatedAt} - moderationOpts={moderationOpts!} - /> - ) + return <FeedItem item={item} moderationOpts={moderationOpts!} /> }, - [onPressRetryLoadMore, dataUpdatedAt, moderationOpts], + [onPressRetryLoadMore, moderationOpts], ) const showHeaderSpinner = !isPTRing && isFetching && !isLoading |