diff options
author | dan <dan.abramov@gmail.com> | 2024-11-04 21:28:27 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-11-04 21:28:27 +0000 |
commit | 174988bc5ab00774d200a882312985f55d903d81 (patch) | |
tree | af52d6f05093ceeea3e3293db0cbab3d5cf43156 /src/view/com/lightbox/Lightbox.tsx | |
parent | ac9d910e1e77c559eff8b32cd8412335f41074f1 (diff) | |
download | voidsky-174988bc5ab00774d200a882312985f55d903d81.tar.zst |
Unify dimensions cache between lightbox and feed (#6047)
* Remove useless memo * Use explicit values when useImageAspectRatio doesn't know It's not very good that you can't distingiush when we haven't loaded vs when we're certain. This shifts the burden of dealing with missing values to the caller. * Check cache early * Handle src change * Rewrite image-sizes.fetch to avoid mixing async styles * Make image-sizes LRU Code is copy paste from useImageDimensions.ts * Rm unused fields * Derive aspect on the fly * Factor useImageDimensions out of useImageAspectRatio * Move useImageDimensions into image-sizes * Make lightbox use the same cache * Wire up known dimensions to the lightbox * Handle division by zero in the hook * Use safe aspect for lightbox calculations
Diffstat (limited to 'src/view/com/lightbox/Lightbox.tsx')
-rw-r--r-- | src/view/com/lightbox/Lightbox.tsx | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/src/view/com/lightbox/Lightbox.tsx b/src/view/com/lightbox/Lightbox.tsx index 891be3f9c..83ea2e941 100644 --- a/src/view/com/lightbox/Lightbox.tsx +++ b/src/view/com/lightbox/Lightbox.tsx @@ -32,7 +32,15 @@ export function Lightbox() { return ( <ImageView images={[ - {uri: opts.profile.avatar || '', thumbUri: opts.profile.avatar || ''}, + { + uri: opts.profile.avatar || '', + thumbUri: opts.profile.avatar || '', + dimensions: { + // It's fine if it's actually smaller but we know it's 1:1. + height: 1000, + width: 1000, + }, + }, ]} initialImageIndex={0} thumbDims={opts.thumbDims} |