about summary refs log tree commit diff
path: root/src/view/com/lightbox/ImageViewing/components
diff options
context:
space:
mode:
authordan <dan.abramov@gmail.com>2023-10-10 23:02:00 +0100
committerGitHub <noreply@github.com>2023-10-10 23:02:00 +0100
commitaad8d12ededa49d5c69e4ddf85993425723be8dd (patch)
tree180ae33fd03071a939c425dcf46b18d497f5568c /src/view/com/lightbox/ImageViewing/components
parent209d8b683c730a14d23c7f57c3ec8c2e9daa2397 (diff)
downloadvoidsky-aad8d12ededa49d5c69e4ddf85993425723be8dd.tar.zst
Fix MobX crash for Android lightbox (#1668)
* Fix MobX crash for Android lightbox

* Reorder props to match between forks
Diffstat (limited to 'src/view/com/lightbox/ImageViewing/components')
-rw-r--r--src/view/com/lightbox/ImageViewing/components/ImageItem/ImageItem.android.tsx3
-rw-r--r--src/view/com/lightbox/ImageViewing/components/ImageItem/ImageItem.ios.tsx1
2 files changed, 3 insertions, 1 deletions
diff --git a/src/view/com/lightbox/ImageViewing/components/ImageItem/ImageItem.android.tsx b/src/view/com/lightbox/ImageViewing/components/ImageItem/ImageItem.android.tsx
index 6fe7854bc..513524864 100644
--- a/src/view/com/lightbox/ImageViewing/components/ImageItem/ImageItem.android.tsx
+++ b/src/view/com/lightbox/ImageViewing/components/ImageItem/ImageItem.android.tsx
@@ -307,8 +307,9 @@ const ImageItem = ({
       )}
       <GestureDetector gesture={composedGesture}>
         <AnimatedImage
-          source={imageSrc}
           contentFit="contain"
+          // NOTE: Don't pass imageSrc={imageSrc} or MobX will break.
+          source={{uri: imageSrc.uri}}
           style={[styles.image, animatedStyle]}
           accessibilityLabel={imageSrc.alt}
           accessibilityHint=""
diff --git a/src/view/com/lightbox/ImageViewing/components/ImageItem/ImageItem.ios.tsx b/src/view/com/lightbox/ImageViewing/components/ImageItem/ImageItem.ios.tsx
index 1bd24a841..cd550670c 100644
--- a/src/view/com/lightbox/ImageViewing/components/ImageItem/ImageItem.ios.tsx
+++ b/src/view/com/lightbox/ImageViewing/components/ImageItem/ImageItem.ios.tsx
@@ -143,6 +143,7 @@ const ImageItem = ({imageSrc, onZoom, onRequestClose}: Props) => {
           accessibilityHint="">
           <AnimatedImage
             contentFit="contain"
+            // NOTE: Don't pass imageSrc={imageSrc} or MobX will break.
             source={{uri: imageSrc.uri}}
             style={[styles.image, animatedStyle]}
             onLoad={() => setLoaded(true)}