diff options
| author | dan <dan.abramov@gmail.com> | 2024-11-09 22:34:46 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-11-09 22:34:46 +0000 |
| commit | 2d73c5a24cf8ad06dbebcf44c8f4f053eedda5a4 (patch) | |
| tree | 06e69c967f97d4d3fe6b4ba3f77efd66d85af2ae /src/state/lightbox.tsx | |
| parent | e73d5c6c207a5da842cdb02a703ef3f130112fa2 (diff) | |
| download | voidsky-2d73c5a24cf8ad06dbebcf44c8f4f053eedda5a4.tar.zst | |
[Lightbox] Open animation (#6159)
* Measure all rects for embeds * Measure avi rects too * Animate lightbox in and out * Account for safe area in the animation * Tune spring times * Remove null checks for measurements * Remove superfluous view * Block swipe while opening * Interpolate width/height on native side for Android * Make it fast by animating only affine transforms * Fix tall image final state The initial animation frame is still off on both platforms. * Try to squeeze perf * Avoid blank images during animation on iOS * Fix bad rebase * Fix a huge memory issue due to expo/expo#24894 * Fix last frame flash * Fix thum dim calculation for tall images
Diffstat (limited to 'src/state/lightbox.tsx')
| -rw-r--r-- | src/state/lightbox.tsx | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/state/lightbox.tsx b/src/state/lightbox.tsx index 06541106e..67a450991 100644 --- a/src/state/lightbox.tsx +++ b/src/state/lightbox.tsx @@ -1,5 +1,4 @@ import React from 'react' -import type {MeasuredDimensions} from 'react-native-reanimated' import {nanoid} from 'nanoid/non-secure' import {useNonReactiveCallback} from '#/lib/hooks/useNonReactiveCallback' @@ -8,7 +7,6 @@ import {ImageSource} from '#/view/com/lightbox/ImageViewing/@types' export type Lightbox = { id: string images: ImageSource[] - thumbDims: MeasuredDimensions | null index: number } |