diff options
author | Paul Frazee <pfrazee@gmail.com> | 2024-05-06 16:55:57 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-05-06 16:55:57 -0700 |
commit | 901feba6db9467ce9b75a78128fa305fc3370c7e (patch) | |
tree | 14dd8d8352f2a538e6b4c61b5bcf54924e6ab583 /__tests__ | |
parent | 2ca4b74955244f23aa40ac2d98267e301a59793c (diff) | |
download | voidsky-901feba6db9467ce9b75a78128fa305fc3370c7e.tar.zst |
Replace pluralize by plural by @tkusano (#3882)
* Replace pluralize with plural or Plural * Replace all pluralize (defined by src/lib/strings/helpers.ts) with plural or Plural (defined by @lingui/macro) to make some UI elements translatable. * Delete pluralize() and related test. * Import @formatjs polyfill libraries for plural on ios and android - ios and andorid: import `@formtjs/intl-locale` and `@formatjs/intl-pluralrules` to polyfill `Intl.Locale` and `Intl.PluralRules` which are used in `plural()` and '<Plural />'. - update `plural` use in notification messages for better translation. * Rewrite to pass lint * Add Catalan plural polyfill * more replacement * import zh plural data for zh-CN * Refactor feed header components (#2964) * Move home-related files to view/com/home * Add HomeHeader in front of FeedTabBar * Move isDekstop check outside FeedsTabBar * Remove PWI logic from tabbar * Separate platform-specific layout from shared logic * Rename Home Feed Prefs to Following Feed Prefs (#2965) * use `useOpenLink` hook for links in ALF (#2975) * use `useOpenLink` hook for links in ALF * web only for `outline` * increase timeout to 15s (#2958) * Normalize relative day (#2874) * fix: normalize relative date * chore: add comments * refactor: skip flooring normalized diff * refactor: let -> const * fix: get own copy of date to prevent mutating * refactor: rounding does the same trick * Add handle validation to create account UI (#2959) * show uiState errors in the box as well simplify copy update ui for only letters and numbers add ui validation to handle selection * simplify names * Fix accidental text-node render --------- Co-authored-by: Paul Frazee <pfrazee@gmail.com> * Make dim theme dim (#2966) * Make dim color scheme dim * Tweaks * Overall tweaks * We have to go darker * Tweak saturation of blues in dim * Increase contrast on dark-dark mode * adjust dim --------- Co-authored-by: Eric Bailey <git@esb.lol> Co-authored-by: Paul Frazee <pfrazee@gmail.com> Co-authored-by: Hailey <me@haileyok.com> * Fix dim mode unread notif color * use `showControls` to show/hide live text icon on ios (#2982) * Update .po files * fix reversed icons in validator 🤦 (#2991) * Adjust `windowSize` on `PostThread` `FlatList` (#2989) * adjust window size, cells batching period * rm batching period change * Pluralize 'follow(s)' * Include a space between the msgid count and "follower(s)/following(s)" so the translator can adjust the translated count line to fit within the Drawer. * pluralie '# following' * Fix & Update * Rewrite to use Plural * rmeove unused import * When commiting changes, disable 'simple-import-sort' plugin in .eslintrc.js to sync with bluesky-social:main * Revert simple-import-sort/imports related changes * Move ProfileHoverCard web to plural util * Followings -> following * Add plural following to hovercard * Followings -> Following --------- Co-authored-by: Takayuki KUSANO <kusano@tkusano.jp> Co-authored-by: Takayuki KUSANO <65759+tkusano@users.noreply.github.com> Co-authored-by: dan <dan.abramov@gmail.com> Co-authored-by: Hailey <me@haileyok.com> Co-authored-by: Mary <148872143+mary-ext@users.noreply.github.com> Co-authored-by: Eric Bailey <git@esb.lol>
Diffstat (limited to '__tests__')
-rw-r--r-- | __tests__/lib/string.test.ts | 31 |
1 files changed, 1 insertions, 30 deletions
diff --git a/__tests__/lib/string.test.ts b/__tests__/lib/string.test.ts index 2f603a521..c8a209dfa 100644 --- a/__tests__/lib/string.test.ts +++ b/__tests__/lib/string.test.ts @@ -3,7 +3,7 @@ import {RichText} from '@atproto/api' import {parseEmbedPlayerFromUrl} from 'lib/strings/embed-player' import {cleanError} from '../../src/lib/strings/errors' import {createFullHandle, makeValidHandle} from '../../src/lib/strings/handles' -import {enforceLen, pluralize} from '../../src/lib/strings/helpers' +import {enforceLen} from '../../src/lib/strings/helpers' import {detectLinkables} from '../../src/lib/strings/rich-text-detection' import {shortenLinks} from '../../src/lib/strings/rich-text-manip' import {ago} from '../../src/lib/strings/time' @@ -127,35 +127,6 @@ describe('detectLinkables', () => { }) }) -describe('pluralize', () => { - const inputs: [number, string, string?][] = [ - [1, 'follower'], - [1, 'member'], - [100, 'post'], - [1000, 'repost'], - [10000, 'upvote'], - [100000, 'other'], - [2, 'man', 'men'], - ] - const outputs = [ - 'follower', - 'member', - 'posts', - 'reposts', - 'upvotes', - 'others', - 'men', - ] - - it('correctly pluralizes a set of words', () => { - for (let i = 0; i < inputs.length; i++) { - const input = inputs[i] - const output = pluralize(...input) - expect(output).toEqual(outputs[i]) - } - }) -}) - describe('makeRecordUri', () => { const inputs: [string, string, string][] = [ ['alice.test', 'app.bsky.feed.post', '3jk7x4irgv52r'], |