#995 use `asAnchor` on external embeds (
#1043)
* use asAnchor on external embeds
* add noFeedback back, fix TouchableWithoutFeedback anchor handling
2 files changed, 5 insertions, 5 deletions
diff --git a/src/view/com/util/Link.tsx b/src/view/com/util/Link.tsx
index 454fd7c21..e428960fe 100644
--- a/src/view/com/util/Link.tsx
+++ b/src/view/com/util/Link.tsx
@@ -89,12 +89,11 @@ export const Link = observer(function Link({
<TouchableWithoutFeedback
testID={testID}
onPress={onPress}
- // @ts-ignore web only -prf
- href={asAnchor ? sanitizeUrl(href) : undefined}
accessible={accessible}
accessibilityRole="link"
{...props}>
- <View style={style}>
+ {/* @ts-ignore web only -prf */}
+ <View style={style} href={asAnchor ? sanitizeUrl(href) : undefined}>
{children ? children : <Text>{title || 'link'}</Text>}
</View>
</TouchableWithoutFeedback>
diff --git a/src/view/com/util/post-embeds/index.tsx b/src/view/com/util/post-embeds/index.tsx
index 372b36359..7ffebff54 100644
--- a/src/view/com/util/post-embeds/index.tsx
+++ b/src/view/com/util/post-embeds/index.tsx
@@ -181,9 +181,10 @@ export function PostEmbeds({
return (
<Link
+ asAnchor
+ noFeedback
style={[styles.extOuter, pal.view, pal.border, style]}
- href={link.uri}
- noFeedback>
+ href={link.uri}>
<ExternalLinkEmbed link={link} />
</Link>
)
|