about summary refs log tree commit diff
diff options
context:
space:
mode:
authorPaul Frazee <pfrazee@gmail.com>2023-10-10 10:57:09 -0700
committerGitHub <noreply@github.com>2023-10-10 10:57:09 -0700
commitbc2c44cb987742f0db873317cbf38fbf202a8b42 (patch)
tree0301e056b314e0c6692dcba231bdbe9f766c2188
parent098f4b526ebbd62fd2517a55e46f1419f277f904 (diff)
downloadvoidsky-bc2c44cb987742f0db873317cbf38fbf202a8b42.tar.zst
Only prompt users once to verify email (according to local storage) close #1657 (#1658)
-rw-r--r--src/state/models/ui/reminders.ts12
1 files changed, 6 insertions, 6 deletions
diff --git a/src/state/models/ui/reminders.ts b/src/state/models/ui/reminders.ts
index 60dbf5d88..c650de004 100644
--- a/src/state/models/ui/reminders.ts
+++ b/src/state/models/ui/reminders.ts
@@ -3,10 +3,8 @@ import {isObj, hasProp} from 'lib/type-guards'
 import {RootStoreModel} from '../root-store'
 import {toHashCode} from 'lib/strings/helpers'
 
-const DAY = 60e3 * 24 * 1 // 1 day (ms)
-
 export class Reminders {
-  lastEmailConfirm: Date = new Date()
+  lastEmailConfirm: Date | null = null
 
   constructor(public rootStore: RootStoreModel) {
     makeAutoObservable(
@@ -45,6 +43,10 @@ export class Reminders {
     if (this.rootStore.onboarding.isActive) {
       return false
     }
+    // only prompt once
+    if (this.lastEmailConfirm) {
+      return false
+    }
     const today = new Date()
     // shard the users into 2 day of the week buckets
     // (this is to avoid a sudden influx of email updates when
@@ -53,9 +55,7 @@ export class Reminders {
     if (code !== today.getDay() && code !== (today.getDay() + 1) % 7) {
       return false
     }
-    // only ask once a day at most, but because of the bucketing
-    // this will be more like weekly
-    return Number(today) - Number(this.lastEmailConfirm) > DAY
+    return true
   }
 
   setEmailConfirmationRequested() {