diff options
author | Hailey <me@haileyok.com> | 2024-05-30 17:52:56 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-05-31 01:52:56 +0100 |
commit | 8e2c21a8823b06b408297608d347dd9392d60ee3 (patch) | |
tree | 15a7a7fa82c81f45982d6b5462b788a13e1a399e | |
parent | d6275e98c24ae12f070a689eb5602ac08b6abbb7 (diff) | |
download | voidsky-8e2c21a8823b06b408297608d347dd9392d60ee3.tar.zst |
Don't log downsample warning when unnecessary (#4291)
* fix log use process.env ensure the log happens regardless of `isDownsampledSession` fix log * oops, revert test
-rw-r--r-- | src/lib/statsig/statsig.tsx | 17 |
1 files changed, 10 insertions, 7 deletions
diff --git a/src/lib/statsig/statsig.tsx b/src/lib/statsig/statsig.tsx index 573a123e1..166d468a1 100644 --- a/src/lib/statsig/statsig.tsx +++ b/src/lib/statsig/statsig.tsx @@ -102,16 +102,19 @@ export function logEvent<E extends keyof LogEvents>( rawMetadata: LogEvents[E] & FlatJSONRecord, ) { try { + if ( + process.env.NODE_ENV === 'development' && + eventName.endsWith(':sampled') && + !DOWNSAMPLED_EVENTS.has(eventName) + ) { + logger.error( + 'Did you forget to add ' + eventName + ' to DOWNSAMPLED_EVENTS?', + ) + } + if (isDownsampledSession && DOWNSAMPLED_EVENTS.has(eventName)) { return } - if (process.env.NODE_ENV === 'development') { - if (eventName.endsWith(':sampled')) { - logger.error( - 'Did you forget to add ' + eventName + ' to DOWNSAMPLED_EVENTS?', - ) - } - } const fullMetadata = { ...rawMetadata, } as Record<string, string> // Statsig typings are unnecessarily strict here. |