diff options
| author | Eric Bailey <git@esb.lol> | 2024-06-18 14:09:40 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-06-18 14:09:40 -0500 |
| commit | 502bcad7017d72fb23c40a268b1e220f892db7da (patch) | |
| tree | 8d9ce32a1405be7ecb98630f74c11d54f217df90 | |
| parent | d6ce16d15ae79c4fef943cd48dfa0cdb072e9596 (diff) | |
| download | voidsky-502bcad7017d72fb23c40a268b1e220f892db7da.tar.zst | |
Disable newskie dialog tap in hover card web (#4562)
| -rw-r--r-- | src/components/NewskieDialog.tsx | 3 | ||||
| -rw-r--r-- | src/components/ProfileHoverCard/index.web.tsx | 2 | ||||
| -rw-r--r-- | src/screens/Profile/Header/Handle.tsx | 6 |
3 files changed, 8 insertions, 3 deletions
diff --git a/src/components/NewskieDialog.tsx b/src/components/NewskieDialog.tsx index 281430e31..0354bfc43 100644 --- a/src/components/NewskieDialog.tsx +++ b/src/components/NewskieDialog.tsx @@ -18,8 +18,10 @@ import {Text} from '#/components/Typography' export function NewskieDialog({ profile, + disabled, }: { profile: AppBskyActorDefs.ProfileViewDetailed + disabled?: boolean }) { const {_} = useLingui() const moderationOpts = useModerationOpts() @@ -43,6 +45,7 @@ export function NewskieDialog({ return ( <View style={[a.pr_2xs]}> <Button + disabled={disabled} label={_( msg`This user is new here. Press for more info about when they joined.`, )} diff --git a/src/components/ProfileHoverCard/index.web.tsx b/src/components/ProfileHoverCard/index.web.tsx index 4f110485e..319eccfa4 100644 --- a/src/components/ProfileHoverCard/index.web.tsx +++ b/src/components/ProfileHoverCard/index.web.tsx @@ -469,7 +469,7 @@ function Inner({ )} </Text> - <ProfileHeaderHandle profile={profileShadow} /> + <ProfileHeaderHandle profile={profileShadow} disableTaps /> </View> </Link> diff --git a/src/screens/Profile/Header/Handle.tsx b/src/screens/Profile/Header/Handle.tsx index 4f438a286..268b7350f 100644 --- a/src/screens/Profile/Header/Handle.tsx +++ b/src/screens/Profile/Header/Handle.tsx @@ -12,8 +12,10 @@ import {Text} from '#/components/Typography' export function ProfileHeaderHandle({ profile, + disableTaps, }: { profile: Shadow<AppBskyActorDefs.ProfileViewDetailed> + disableTaps?: boolean }) { const t = useTheme() const invalidHandle = isInvalidHandle(profile.handle) @@ -21,8 +23,8 @@ export function ProfileHeaderHandle({ return ( <View style={[a.flex_row, a.gap_xs, a.align_center]} - pointerEvents={isAndroid ? 'box-only' : 'auto'}> - <NewskieDialog profile={profile} /> + pointerEvents={disableTaps ? 'none' : isAndroid ? 'box-only' : 'auto'}> + <NewskieDialog profile={profile} disabled={disableTaps} /> {profile.viewer?.followedBy && !blockHide ? ( <View style={[t.atoms.bg_contrast_25, a.rounded_xs, a.px_sm, a.py_xs]}> <Text style={[t.atoms.text, a.text_sm]}> |