about summary refs log tree commit diff
diff options
context:
space:
mode:
authorAryan Goharzad <arrygoo@gmail.com>2023-01-24 12:03:18 -0500
committerGitHub <noreply@github.com>2023-01-24 11:03:18 -0600
commit3a90114f3afc66cfef70c71c2ee343c29e1f3e8d (patch)
tree6a7dea171afc9d4306e93c6adce22d47f802526f
parent9027882fb401df2a9df6a89facb2bdb94b8b731b (diff)
downloadvoidsky-3a90114f3afc66cfef70c71c2ee343c29e1f3e8d.tar.zst
more prettier and lint cleanup (#82)
* more prettier and lint cleanup

* Fixes more lint issues

* lint

* ignore more files

* remove todos

* lint
-rw-r--r--.eslintrc.js8
-rw-r--r--.github/workflows/lint.yml2
-rw-r--r--.prettierignore5
-rw-r--r--src/state/lib/api.ts8
-rw-r--r--src/view/com/composer/Autocomplete.tsx1
-rw-r--r--src/view/com/modals/ReportAccount.tsx2
-rw-r--r--src/view/com/modals/ReportPost.tsx2
-rw-r--r--src/view/com/modals/ServerInput.tsx8
-rw-r--r--src/view/com/util/UserBanner.tsx2
-rw-r--r--src/view/com/util/UserInfoText.tsx2
-rw-r--r--src/view/screens/Contacts.tsx2
-rw-r--r--src/view/shell/mobile/index.tsx1
12 files changed, 18 insertions, 25 deletions
diff --git a/.eslintrc.js b/.eslintrc.js
index 701cc2916..9a9b2fe4a 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -3,7 +3,13 @@ module.exports = {
   extends: '@react-native-community',
   parser: '@typescript-eslint/parser',
   plugins: ['@typescript-eslint'],
-  ignorePatterns: ['**/__mocks__/*.ts', 'src/third-party', 'ios', 'android'],
+  ignorePatterns: [
+    '**/__mocks__/*.ts',
+    'src/third-party',
+    'ios',
+    'android',
+    'coverage',
+  ],
   overrides: [
     {
       files: ['*.js', '*.mjs', '*.ts', '*.tsx'],
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index e645284fb..54c0ae839 100644
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -30,5 +30,5 @@ jobs:
       - name: Yarn install
         run: yarn
       - name: Run tests
-        run: | 
+        run: |
           yarn test --forceExit
diff --git a/.prettierignore b/.prettierignore
new file mode 100644
index 000000000..2ec214a3b
--- /dev/null
+++ b/.prettierignore
@@ -0,0 +1,5 @@
+ios
+android
+src/third-party
+src/app.json
+public
\ No newline at end of file
diff --git a/src/state/lib/api.ts b/src/state/lib/api.ts
index 2738ba209..e498bef1b 100644
--- a/src/state/lib/api.ts
+++ b/src/state/lib/api.ts
@@ -14,13 +14,7 @@ import {AtUri} from '../../third-party/uri'
 import {RootStoreModel} from '../models/root-store'
 import {extractEntities} from '../../lib/strings'
 import {isNetworkError} from '../../lib/errors'
-import {downloadAndResize} from '../../lib/images'
-import {
-  getLikelyType,
-  LikelyType,
-  getLinkMeta,
-  LinkMeta,
-} from '../../lib/link-meta'
+import {LinkMeta} from '../../lib/link-meta'
 import {Image} from '../../lib/images'
 
 const TIMEOUT = 10e3 // 10s
diff --git a/src/view/com/composer/Autocomplete.tsx b/src/view/com/composer/Autocomplete.tsx
index d3f99627c..94381e644 100644
--- a/src/view/com/composer/Autocomplete.tsx
+++ b/src/view/com/composer/Autocomplete.tsx
@@ -7,7 +7,6 @@ import {
 } from 'react-native'
 import {useAnimatedValue} from '../../lib/hooks/useAnimatedValue'
 import {Text} from '../util/text/Text'
-import {colors} from '../../lib/styles'
 import {usePalette} from '../../lib/hooks/usePalette'
 
 interface AutocompleteItem {
diff --git a/src/view/com/modals/ReportAccount.tsx b/src/view/com/modals/ReportAccount.tsx
index f0b02ae3c..1385d5711 100644
--- a/src/view/com/modals/ReportAccount.tsx
+++ b/src/view/com/modals/ReportAccount.tsx
@@ -20,7 +20,7 @@ const ITEMS: RadioGroupItem[] = [
 
 export const snapPoints = ['50%']
 
-export function Component({did}: {did: string}) {
+export function Component() {
   const store = useStores()
   const [isProcessing, setIsProcessing] = useState<boolean>(false)
   const [error, setError] = useState<string>('')
diff --git a/src/view/com/modals/ReportPost.tsx b/src/view/com/modals/ReportPost.tsx
index 1435a723f..8a3a1f758 100644
--- a/src/view/com/modals/ReportPost.tsx
+++ b/src/view/com/modals/ReportPost.tsx
@@ -21,7 +21,7 @@ const ITEMS: RadioGroupItem[] = [
 
 export const snapPoints = ['50%']
 
-export function Component({postUrl}: {postUrl: string}) {
+export function Component() {
   const store = useStores()
   const [isProcessing, setIsProcessing] = useState<boolean>(false)
   const [error, setError] = useState<string>('')
diff --git a/src/view/com/modals/ServerInput.tsx b/src/view/com/modals/ServerInput.tsx
index c8174f3cd..8792d70f1 100644
--- a/src/view/com/modals/ServerInput.tsx
+++ b/src/view/com/modals/ServerInput.tsx
@@ -14,13 +14,7 @@ import {LOGIN_INCLUDE_DEV_SERVERS} from '../../../build-flags'
 
 export const snapPoints = ['80%']
 
-export function Component({
-  initialService,
-  onSelect,
-}: {
-  initialService: string
-  onSelect: (url: string) => void
-}) {
+export function Component({onSelect}: {onSelect: (url: string) => void}) {
   const store = useStores()
   const [customUrl, setCustomUrl] = useState<string>('')
 
diff --git a/src/view/com/util/UserBanner.tsx b/src/view/com/util/UserBanner.tsx
index 1863e1883..5ce638351 100644
--- a/src/view/com/util/UserBanner.tsx
+++ b/src/view/com/util/UserBanner.tsx
@@ -11,11 +11,9 @@ import {
 } from 'react-native-image-crop-picker'
 
 export function UserBanner({
-  handle,
   banner,
   onSelectNewBanner,
 }: {
-  handle: string
   banner?: string | null
   onSelectNewBanner?: (img: PickedImage) => void
 }) {
diff --git a/src/view/com/util/UserInfoText.tsx b/src/view/com/util/UserInfoText.tsx
index 5cdfd1345..151fa54d0 100644
--- a/src/view/com/util/UserInfoText.tsx
+++ b/src/view/com/util/UserInfoText.tsx
@@ -11,7 +11,6 @@ export function UserInfoText({
   type = 'md',
   did,
   attr,
-  loading,
   failed,
   prefix,
   style,
@@ -27,7 +26,6 @@ export function UserInfoText({
   asLink?: boolean
 }) {
   attr = attr || 'handle'
-  loading = loading || '...'
   failed = failed || 'user'
 
   const store = useStores()
diff --git a/src/view/screens/Contacts.tsx b/src/view/screens/Contacts.tsx
index 600cd78c6..a6cc7244e 100644
--- a/src/view/screens/Contacts.tsx
+++ b/src/view/screens/Contacts.tsx
@@ -9,7 +9,7 @@ import {ScreenParams} from '../routes'
 import {useStores} from '../../state'
 import {useAnimatedValue} from '../lib/hooks/useAnimatedValue'
 
-export const Contacts = ({navIdx, visible, params}: ScreenParams) => {
+export const Contacts = ({navIdx, visible}: ScreenParams) => {
   const store = useStores()
   const selectorInterp = useAnimatedValue(0)
 
diff --git a/src/view/shell/mobile/index.tsx b/src/view/shell/mobile/index.tsx
index b999d05d9..fb14211eb 100644
--- a/src/view/shell/mobile/index.tsx
+++ b/src/view/shell/mobile/index.tsx
@@ -125,7 +125,6 @@ export const MobileShell: React.FC = observer(() => {
   const scrollElRef = useRef<FlatList | undefined>()
   const winDim = useWindowDimensions()
   const [menuSwipingDirection, setMenuSwipingDirection] = useState(0)
-  const constZeroInterp = useAnimatedValue(0)
   const swipeGestureInterp = useAnimatedValue(0)
   const minimalShellInterp = useAnimatedValue(0)
   const tabMenuInterp = useAnimatedValue(0)