diff options
| author | Mary <148872143+mary-ext@users.noreply.github.com> | 2024-04-14 02:02:22 +0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-04-13 12:02:22 -0700 |
| commit | 196dd3a8abdc4ebdd0a73c5f6afe2acca38d8efc (patch) | |
| tree | 733ba5eb4ce1d0c2114cc2d6e0ce76c848be14cc | |
| parent | a8c1e71907c146071f12ecf22abb2fcbedfc3b54 (diff) | |
| download | voidsky-196dd3a8abdc4ebdd0a73c5f6afe2acca38d8efc.tar.zst | |
Increase hit slop for web's app language picker (#3535)
* fix: make app language picker tap region larger * fix: add right padding on drawer signup card noticeable on portuguese language * fix: mimic hitSlop
| -rw-r--r-- | src/components/AppLanguageDropdown.web.tsx | 11 | ||||
| -rw-r--r-- | src/view/shell/Drawer.tsx | 4 |
2 files changed, 13 insertions, 2 deletions
diff --git a/src/components/AppLanguageDropdown.web.tsx b/src/components/AppLanguageDropdown.web.tsx index 302a30ca6..8052a4ef3 100644 --- a/src/components/AppLanguageDropdown.web.tsx +++ b/src/components/AppLanguageDropdown.web.tsx @@ -29,7 +29,16 @@ export function AppLanguageDropdown() { ) return ( - <View style={[a.flex_row, a.gap_sm, a.align_center, a.flex_shrink]}> + <View + style={[ + // We don't have hitSlop here to increase the tap region, + // alternative is negative margins. + {height: 32, marginVertical: -((32 - 14) / 2)}, + a.flex_row, + a.gap_sm, + a.align_center, + a.flex_shrink, + ]}> <Text aria-hidden={true} style={t.atoms.text_contrast_medium}> {APP_LANGUAGES.find(l => l.code2 === sanitizedLang)?.name} </Text> diff --git a/src/view/shell/Drawer.tsx b/src/view/shell/Drawer.tsx index a7342179d..3972797b7 100644 --- a/src/view/shell/Drawer.tsx +++ b/src/view/shell/Drawer.tsx @@ -224,7 +224,9 @@ let DrawerContent = ({}: {}): React.ReactNode => { /> </View> ) : ( - <NavSignupCard /> + <View style={{paddingRight: 20}}> + <NavSignupCard /> + </View> )} {hasSession ? ( |