about summary refs log tree commit diff
path: root/.eslintrc.js
diff options
context:
space:
mode:
authordan <dan.abramov@gmail.com>2024-04-05 15:09:35 +0100
committerGitHub <noreply@github.com>2024-04-05 15:09:35 +0100
commit46c112edfdcb40681a8997ec4f47b413a08fdd14 (patch)
tree8745de3a743f9231a5151296c2df4fd6e39404e7 /.eslintrc.js
parent49266c355ea781cbd7a0b373e64143da7740c91e (diff)
downloadvoidsky-46c112edfdcb40681a8997ec4f47b413a08fdd14.tar.zst
Enforce that text is wrapped in <Text>, remaining cases (#3421)
* Toggle.Button -> Toggle.ButtonWithText

* Simplify Prompt.Cancel/Action

* Move lines down for better diff

* Remove ButtonWithText

* Simplify types

* Enforce Button/ButtonText nesting

* Add suggested wrapper in linter error

* Check <Trans> ancestry too

* Also check literals

* Rm ts-ignore
Diffstat (limited to '.eslintrc.js')
-rw-r--r--.eslintrc.js15
1 files changed, 5 insertions, 10 deletions
diff --git a/.eslintrc.js b/.eslintrc.js
index df0c76230..a999fd24b 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -23,17 +23,12 @@ module.exports = {
     'bsky-internal/avoid-unwrapped-text': [
       'error',
       {
-        impliedTextComponents: [
-          'Button', // TODO: Not always safe.
-          'H1',
-          'H2',
-          'H3',
-          'H4',
-          'H5',
-          'H6',
-          'P',
-        ],
+        impliedTextComponents: ['H1', 'H2', 'H3', 'H4', 'H5', 'H6', 'P'],
         impliedTextProps: [],
+        suggestedTextWrappers: {
+          Button: 'ButtonText',
+          'ToggleButton.Button': 'ToggleButton.ButtonText',
+        },
       },
     ],
     'simple-import-sort/imports': [