StorageError: use std::borrow::Cow for msg field

This allows avoiding an unnecessary allocation whenever the error
message is static.

1 files changed, 5 insertions, 5 deletions

diff --git a/kittybox-rs/src/database/memory.rs b/kittybox-rs/src/database/memory.rs
index 2fb55e5..9d79ecc 100644
--- a/kittybox-rs/src/database/memory.rs
+++ b/kittybox-rs/src/database/memory.rs
@@ -46,7 +46,7 @@ impl Storage for MemoryStorage {
         let key: &str = match post["properties"]["uid"][0].as_str() {
             Some(uid) => uid,
             None => {
-                return Err(StorageError::new(
+                return Err(StorageError::from_static(
                     ErrorKind::Other,
                     "post doesn't have a UID",
                 ))
@@ -108,7 +108,7 @@ impl Storage for MemoryStorage {
                         .or_default()
                         .extend(v.clone());
                 } else {
-                    return Err(StorageError::new(
+                    return Err(StorageError::from_static(
                         ErrorKind::BadRequest,
                         "Malformed update object",
                     ));
@@ -120,7 +120,7 @@ impl Storage for MemoryStorage {
                 if v.is_array() {
                     add_keys.insert(k.to_string(), v.clone());
                 } else {
-                    return Err(StorageError::new(
+                    return Err(StorageError::from_static(
                         ErrorKind::BadRequest,
                         "Malformed update object",
                     ));
@@ -139,7 +139,7 @@ impl Storage for MemoryStorage {
                 if let Some(new_post) = mapping.get(url) {
                     post = new_post
                 } else {
-                    return Err(StorageError::new(
+                    return Err(StorageError::from_static(
                         ErrorKind::NotFound,
                         "The post you have requested is not found in the database.",
                     ));
@@ -191,7 +191,7 @@ impl Storage for MemoryStorage {
                 post,
             );
         } else {
-            return Err(StorageError::new(
+            return Err(StorageError::from_static(
                 ErrorKind::NotFound,
                 "The designated post wasn't found in the database.",
             ));