From 1b4fee3e43003d73a2de6a1bf0524bdf092dcc8f Mon Sep 17 00:00:00 2001 From: Samuel Newman Date: Sat, 7 Sep 2024 20:15:15 +0100 Subject: [Video] Open the floodgates (partially) (#5208) --- src/lib/statsig/gates.ts | 1 - src/view/com/posts/FeedItem.tsx | 22 +--------------------- src/view/com/util/post-embeds/VideoEmbed.tsx | 7 ------- 3 files changed, 1 insertion(+), 29 deletions(-) (limited to 'src') diff --git a/src/lib/statsig/gates.ts b/src/lib/statsig/gates.ts index 31736629c..1a234e003 100644 --- a/src/lib/statsig/gates.ts +++ b/src/lib/statsig/gates.ts @@ -2,6 +2,5 @@ export type Gate = // Keep this alphabetic please. | 'debug_show_feedcontext' | 'suggested_feeds_interstitial' - | 'video_debug' // not recommended | 'video_upload' // upload videos | 'video_view_on_posts' // see posted videos diff --git a/src/view/com/posts/FeedItem.tsx b/src/view/com/posts/FeedItem.tsx index 6c1bb04c3..7537a4644 100644 --- a/src/view/com/posts/FeedItem.tsx +++ b/src/view/com/posts/FeedItem.tsx @@ -1,4 +1,4 @@ -import React, {memo, useId, useMemo, useState} from 'react' +import React, {memo, useMemo, useState} from 'react' import {StyleSheet, View} from 'react-native' import { AppBskyActorDefs, @@ -21,7 +21,6 @@ import {isReasonFeedSource, ReasonFeedSource} from '#/lib/api/feed/types' import {MAX_POST_LINES} from '#/lib/constants' import {usePalette} from '#/lib/hooks/usePalette' import {makeProfileLink} from '#/lib/routes/links' -import {useGate} from '#/lib/statsig/statsig' import {sanitizeDisplayName} from '#/lib/strings/display-names' import {sanitizeHandle} from '#/lib/strings/handles' import {countLines} from '#/lib/strings/helpers' @@ -47,7 +46,6 @@ import {AppModerationCause} from '#/components/Pills' import {ProfileHoverCard} from '#/components/ProfileHoverCard' import {RichText} from '#/components/RichText' import {Link, TextLink, TextLinkOnWebOnly} from '../util/Link' -import {VideoEmbed} from '../util/post-embeds/VideoEmbed' import {AviFollowButton} from './AviFollowButton' interface FeedItemProps { @@ -386,7 +384,6 @@ let FeedItemInner = ({ post={post} threadgateRecord={threadgateRecord} /> - - ) -} - const styles = StyleSheet.create({ outer: { paddingLeft: 10, diff --git a/src/view/com/util/post-embeds/VideoEmbed.tsx b/src/view/com/util/post-embeds/VideoEmbed.tsx index 9c3a34dda..3175266e4 100644 --- a/src/view/com/util/post-embeds/VideoEmbed.tsx +++ b/src/view/com/util/post-embeds/VideoEmbed.tsx @@ -7,7 +7,6 @@ import {msg, Trans} from '@lingui/macro' import {useLingui} from '@lingui/react' import {clamp} from '#/lib/numbers' -import {useGate} from '#/lib/statsig/statsig' import {useAutoplayDisabled} from 'state/preferences' import {VideoEmbedInnerNative} from '#/view/com/util/post-embeds/VideoEmbedInner/VideoEmbedInnerNative' import {atoms as a} from '#/alf' @@ -24,8 +23,6 @@ interface Props { } export function VideoEmbed({embed}: Props) { - const gate = useGate() - const [key, setKey] = useState(0) const renderError = useCallback( @@ -42,10 +39,6 @@ export function VideoEmbed({embed}: Props) { aspectRatio = clamp(aspectRatio, 1 / 1, 3 / 1) } - if (!gate('video_view_on_posts')) { - return null - } - return (