From 7d72dfb1cb514a9ab8ee2874390c667d49a78e8b Mon Sep 17 00:00:00 2001 From: Samuel Newman Date: Tue, 7 May 2024 20:05:40 +0100 Subject: [GIFs] Restore default alt text (#3893) * restore default alt text * factor out gif alt logic + enable require alt text setting * rm console.log * don't prefill input + esc handling * typo * Nits * shorten user alt prefix * Remove unnecessary condition, rename for clarity * Add comment --------- Co-authored-by: Dan Abramov --- src/view/com/util/post-embeds/GifEmbed.tsx | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) (limited to 'src/view/com/util/post-embeds/GifEmbed.tsx') diff --git a/src/view/com/util/post-embeds/GifEmbed.tsx b/src/view/com/util/post-embeds/GifEmbed.tsx index 286b57992..deb82655b 100644 --- a/src/view/com/util/post-embeds/GifEmbed.tsx +++ b/src/view/com/util/post-embeds/GifEmbed.tsx @@ -6,6 +6,7 @@ import {msg, Trans} from '@lingui/macro' import {useLingui} from '@lingui/react' import {HITSLOP_10} from '#/lib/constants' +import {parseAltFromGIFDescription} from '#/lib/gif-alt-text' import {isWeb} from '#/platform/detection' import {EmbedPlayerParams} from 'lib/strings/embed-player' import {useAutoplayDisabled} from 'state/preferences' @@ -116,6 +117,11 @@ export function GifEmbed({ playerRef.current?.toggleAsync() }, []) + const parsedAlt = React.useMemo( + () => parseAltFromGIFDescription(link.description), + [link], + ) + return ( @@ -140,12 +146,10 @@ export function GifEmbed({ onPlayerStateChange={onPlayerStateChange} ref={playerRef} accessibilityHint={_(msg`Animated GIF`)} - accessibilityLabel={link.description.replace('Alt text: ', '')} + accessibilityLabel={parsedAlt.alt} /> - {!hideAlt && link.description.startsWith('Alt text: ') && ( - - )} + {!hideAlt && parsedAlt.isPreferred && } ) -- cgit 1.4.1