From 2a1edab6d4a8e8b4197b10868153a525f918509c Mon Sep 17 00:00:00 2001 From: dan Date: Fri, 13 Oct 2023 15:24:28 +0100 Subject: Don't re-render bars when showing/hiding them (#1691) * Don't re-render bars when showing/hiding them * Fix more cases * Use autorun instead of reaction to fix first render --- src/lib/hooks/useMinimalShellMode.tsx | 35 +++++++++++++++++++---------------- 1 file changed, 19 insertions(+), 16 deletions(-) (limited to 'src/lib/hooks') diff --git a/src/lib/hooks/useMinimalShellMode.tsx b/src/lib/hooks/useMinimalShellMode.tsx index 2a0a4e4d0..68f405dc4 100644 --- a/src/lib/hooks/useMinimalShellMode.tsx +++ b/src/lib/hooks/useMinimalShellMode.tsx @@ -1,4 +1,5 @@ import React from 'react' +import {autorun} from 'mobx' import {useStores} from 'state/index' import {Animated} from 'react-native' import {useAnimatedValue} from 'lib/hooks/useAnimatedValue' @@ -12,22 +13,24 @@ export function useMinimalShellMode() { } React.useEffect(() => { - if (store.shell.minimalShellMode) { - Animated.timing(minimalShellInterp, { - toValue: 1, - duration: 150, - useNativeDriver: true, - isInteraction: false, - }).start() - } else { - Animated.timing(minimalShellInterp, { - toValue: 0, - duration: 150, - useNativeDriver: true, - isInteraction: false, - }).start() - } - }, [minimalShellInterp, store.shell.minimalShellMode]) + return autorun(() => { + if (store.shell.minimalShellMode) { + Animated.timing(minimalShellInterp, { + toValue: 1, + duration: 150, + useNativeDriver: true, + isInteraction: false, + }).start() + } else { + Animated.timing(minimalShellInterp, { + toValue: 0, + duration: 150, + useNativeDriver: true, + isInteraction: false, + }).start() + } + }) + }, [minimalShellInterp, store]) return {footerMinimalShellTransform} } -- cgit 1.4.1