From 6a7b8a279b6113def5d6330ef40801a5484a0b7c Mon Sep 17 00:00:00 2001 From: Elijah Seed-Arita Date: Wed, 23 Jul 2025 15:19:48 -0700 Subject: [APP-1291] prevent GestureActionView from hijacking swipe in a direction which no actions are specified (#8705) Co-authored-by: hailey --- src/lib/custom-animations/GestureActionView.tsx | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) (limited to 'src/lib/custom-animations') diff --git a/src/lib/custom-animations/GestureActionView.tsx b/src/lib/custom-animations/GestureActionView.tsx index ba6952a81..e7fba570b 100644 --- a/src/lib/custom-animations/GestureActionView.tsx +++ b/src/lib/custom-animations/GestureActionView.tsx @@ -1,5 +1,5 @@ import React from 'react' -import {ColorValue, Dimensions, StyleSheet, View} from 'react-native' +import {type ColorValue, Dimensions, StyleSheet, View} from 'react-native' import {Gesture, GestureDetector} from 'react-native-gesture-handler' import Animated, { clamp, @@ -114,11 +114,16 @@ export function GestureActionView({ }, ) + // NOTE(haileyok): + // Absurdly high value so it doesn't interfere with the pan gestures above (i.e., scroll) + // reanimated doesn't offer great support for disabling y/x axes :/ + const effectivelyDisabledOffset = 200 const panGesture = Gesture.Pan() - .activeOffsetX([-10, 10]) - // Absurdly high value so it doesn't interfere with the pan gestures above (i.e., scroll) - // reanimated doesn't offer great support for disabling y/x axes :/ - .activeOffsetY([-200, 200]) + .activeOffsetX([ + actions.leftFirst ? -10 : -effectivelyDisabledOffset, + actions.rightFirst ? 10 : effectivelyDisabledOffset, + ]) + .activeOffsetY([-effectivelyDisabledOffset, effectivelyDisabledOffset]) .onStart(() => { 'worklet' isActive.set(true) -- cgit 1.4.1