From bb949e4f44c4ed1e19c7bddc5779515b419a7022 Mon Sep 17 00:00:00 2001 From: Samuel Newman Date: Mon, 11 Aug 2025 18:37:39 +0300 Subject: Fix translations on Android using PROCESS_TEXT intent (#8486) * use intents to translate text on android * clean up config plugins * restore day night plugin just to be safe * leave a comment for why we can't open translate directly * add todo * fix lockfile lint --- src/components/PostControls/PostMenu/PostMenuItems.tsx | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) (limited to 'src/components/PostControls/PostMenu') diff --git a/src/components/PostControls/PostMenu/PostMenuItems.tsx b/src/components/PostControls/PostMenu/PostMenuItems.tsx index ecc3d0174..3fd919cd3 100644 --- a/src/components/PostControls/PostMenu/PostMenuItems.tsx +++ b/src/components/PostControls/PostMenu/PostMenuItems.tsx @@ -19,6 +19,7 @@ import {useNavigation} from '@react-navigation/native' import {DISCOVER_DEBUG_DIDS} from '#/lib/constants' import {useOpenLink} from '#/lib/hooks/useOpenLink' +import {useTranslate} from '#/lib/hooks/useTranslate' import {getCurrentRoute} from '#/lib/routes/helpers' import {makeProfileLink} from '#/lib/routes/links' import { @@ -28,7 +29,6 @@ import { import {logEvent, useGate} from '#/lib/statsig/statsig' import {richTextToString} from '#/lib/strings/rich-text-helpers' import {toShareUrl} from '#/lib/strings/url-helpers' -import {getTranslatorLink} from '#/locale/helpers' import {logger} from '#/logger' import {type Shadow} from '#/state/cache/post-shadow' import {useProfileShadow} from '#/state/cache/profile-shadow' @@ -118,6 +118,7 @@ let PostMenuItems = ({ const {hidePost} = useHiddenPostsApi() const feedFeedback = useFeedFeedbackContext() const openLink = useOpenLink() + const translate = useTranslate() const navigation = useNavigation() const {mutedWordsDialogControl} = useGlobalDialogsControlContext() const blockPromptControl = useDialogControl() @@ -172,11 +173,6 @@ let PostMenuItems = ({ return makeProfileLink(postAuthor, 'post', urip.rkey) }, [postUri, postAuthor]) - const translatorUrl = getTranslatorLink( - record.text, - langPrefs.primaryLanguage, - ) - const onDeletePost = () => { deletePostMutate({uri: postUri}).then( () => { @@ -234,8 +230,8 @@ let PostMenuItems = ({ Toast.show(_(msg`Copied to clipboard`), 'clipboard-check') } - const onPressTranslate = async () => { - await openLink(translatorUrl, true) + const onPressTranslate = () => { + translate(record.text, langPrefs.primaryLanguage) if ( bsky.dangerousIsType( -- cgit 1.4.1