From d451f82f54974b7b3da1477a7e1f221628860f62 Mon Sep 17 00:00:00 2001 From: Hailey Date: Tue, 27 Feb 2024 15:22:03 -0800 Subject: Share Extension/Intents (#2587) * add native ios code outside of ios project * helper script * going to be a lot of these commits to squash...backing up * save * start of an expo plugin * create info.plist * copy the view controller * maybe working * working * wait working now * working plugin * use current scheme * update intent path * use better params * support text in uri * build * use better encoding * handle images * cleanup ios plugin * android * move bash script to /scripts * handle cases where loaded data is uiimage rather than uri * remove unnecessary logic, allow more than 4 images and just take first 4 * android build plugin * limit images to four on android * use js for plugins, no need to build * revert changes to app config * use correct scheme on android * android readme * move ios extension to /modules * remove unnecessary event * revert typo * plugin readme * scripts readme * add configurable scheme to .env, default to `bluesky` * remove debug * revert .gitignore change * add comment about updating .env to app.config.js for those modifying scheme * modify .env * update android module to use the proper url * update ios extension * remove comment * parse and validate incoming image uris * fix types * rm oops * fix a few typos --- .../shareExtension/withExtensionEntitlements.js | 33 ++++++++++++++++++++++ 1 file changed, 33 insertions(+) create mode 100644 plugins/shareExtension/withExtensionEntitlements.js (limited to 'plugins/shareExtension/withExtensionEntitlements.js') diff --git a/plugins/shareExtension/withExtensionEntitlements.js b/plugins/shareExtension/withExtensionEntitlements.js new file mode 100644 index 000000000..e6bbf9d23 --- /dev/null +++ b/plugins/shareExtension/withExtensionEntitlements.js @@ -0,0 +1,33 @@ +const {withInfoPlist} = require('@expo/config-plugins') +const plist = require('@expo/plist') +const path = require('path') +const fs = require('fs') + +const withExtensionEntitlements = (config, {extensionName}) => { + // eslint-disable-next-line no-shadow + return withInfoPlist(config, config => { + const extensionEntitlementsPath = path.join( + config.modRequest.platformProjectRoot, + extensionName, + `${extensionName}.entitlements`, + ) + + const shareExtensionEntitlements = { + 'com.apple.security.application-groups': [ + `group.${config.ios?.bundleIdentifier}`, + ], + } + + fs.mkdirSync(path.dirname(extensionEntitlementsPath), { + recursive: true, + }) + fs.writeFileSync( + extensionEntitlementsPath, + plist.default.build(shareExtensionEntitlements), + ) + + return config + }) +} + +module.exports = {withExtensionEntitlements} -- cgit 1.4.1 From ed2e6d654e4736b0b15ba4dafd062f850b329774 Mon Sep 17 00:00:00 2001 From: Hailey Date: Tue, 27 Feb 2024 18:34:09 -0800 Subject: Fix entitlements (#3008) --- plugins/shareExtension/withExtensionEntitlements.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'plugins/shareExtension/withExtensionEntitlements.js') diff --git a/plugins/shareExtension/withExtensionEntitlements.js b/plugins/shareExtension/withExtensionEntitlements.js index e6bbf9d23..ffb767b50 100644 --- a/plugins/shareExtension/withExtensionEntitlements.js +++ b/plugins/shareExtension/withExtensionEntitlements.js @@ -14,7 +14,7 @@ const withExtensionEntitlements = (config, {extensionName}) => { const shareExtensionEntitlements = { 'com.apple.security.application-groups': [ - `group.${config.ios?.bundleIdentifier}`, + `group.bsky.app`, ], } -- cgit 1.4.1 From 622d0daad6171ce2fc1c4d7b1f89e04364924c57 Mon Sep 17 00:00:00 2001 From: Paul Frazee Date: Tue, 27 Feb 2024 18:41:53 -0800 Subject: More entitlement fixes --- plugins/shareExtension/withAppEntitlements.js | 2 +- plugins/shareExtension/withExtensionEntitlements.js | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) (limited to 'plugins/shareExtension/withExtensionEntitlements.js') diff --git a/plugins/shareExtension/withAppEntitlements.js b/plugins/shareExtension/withAppEntitlements.js index 6f9136c37..e69091540 100644 --- a/plugins/shareExtension/withAppEntitlements.js +++ b/plugins/shareExtension/withAppEntitlements.js @@ -4,7 +4,7 @@ const withAppEntitlements = config => { // eslint-disable-next-line no-shadow return withEntitlementsPlist(config, async config => { config.modResults['com.apple.security.application-groups'] = [ - `group.${config.ios.bundleIdentifier}`, + `group.bsky.app`, ] return config }) diff --git a/plugins/shareExtension/withExtensionEntitlements.js b/plugins/shareExtension/withExtensionEntitlements.js index ffb767b50..f647c97c0 100644 --- a/plugins/shareExtension/withExtensionEntitlements.js +++ b/plugins/shareExtension/withExtensionEntitlements.js @@ -13,9 +13,7 @@ const withExtensionEntitlements = (config, {extensionName}) => { ) const shareExtensionEntitlements = { - 'com.apple.security.application-groups': [ - `group.bsky.app`, - ], + 'com.apple.security.application-groups': [`group.bsky.app`], } fs.mkdirSync(path.dirname(extensionEntitlementsPath), { -- cgit 1.4.1 From 00ac76d0fe8f85704f5bd429caf6faa61d01e215 Mon Sep 17 00:00:00 2001 From: Paul Frazee Date: Tue, 27 Feb 2024 19:40:22 -0800 Subject: Fix group id --- plugins/shareExtension/withAppEntitlements.js | 2 +- plugins/shareExtension/withExtensionEntitlements.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'plugins/shareExtension/withExtensionEntitlements.js') diff --git a/plugins/shareExtension/withAppEntitlements.js b/plugins/shareExtension/withAppEntitlements.js index e69091540..4ce81ea61 100644 --- a/plugins/shareExtension/withAppEntitlements.js +++ b/plugins/shareExtension/withAppEntitlements.js @@ -4,7 +4,7 @@ const withAppEntitlements = config => { // eslint-disable-next-line no-shadow return withEntitlementsPlist(config, async config => { config.modResults['com.apple.security.application-groups'] = [ - `group.bsky.app`, + `group.app.bsky`, ] return config }) diff --git a/plugins/shareExtension/withExtensionEntitlements.js b/plugins/shareExtension/withExtensionEntitlements.js index f647c97c0..7bee79d1a 100644 --- a/plugins/shareExtension/withExtensionEntitlements.js +++ b/plugins/shareExtension/withExtensionEntitlements.js @@ -13,7 +13,7 @@ const withExtensionEntitlements = (config, {extensionName}) => { ) const shareExtensionEntitlements = { - 'com.apple.security.application-groups': [`group.bsky.app`], + 'com.apple.security.application-groups': [`group.app.bsky`], } fs.mkdirSync(path.dirname(extensionEntitlementsPath), { -- cgit 1.4.1