From 23a797cfab8182e8f2ebbb6e113177a533afcd3c Mon Sep 17 00:00:00 2001 From: Eric Bailey Date: Fri, 8 Aug 2025 09:57:17 -0500 Subject: Captcha fixes (#8803) * Add env to scripts * Update var name --- .github/workflows/build-submit-android.yml | 1 + .github/workflows/build-submit-ios.yml | 1 + .github/workflows/bundle-deploy-eas-update.yml | 3 +++ .github/workflows/pull-request-comment.yml | 1 + src/env/common.ts | 10 ++++++---- 5 files changed, 12 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build-submit-android.yml b/.github/workflows/build-submit-android.yml index f1e75f87e..27724060e 100644 --- a/.github/workflows/build-submit-android.yml +++ b/.github/workflows/build-submit-android.yml @@ -75,6 +75,7 @@ jobs: echo "EXPO_PUBLIC_BUNDLE_DATE=$(date -u +"%y%m%d%H")" >> .env echo "EXPO_PUBLIC_SENTRY_DSN=${{ secrets.SENTRY_DSN }}" >> .env echo "EXPO_PUBLIC_BITDRIFT_API_KEY=${{ secrets.BITDRIFT_API_KEY }}" >> .env + echo "EXPO_PUBLIC_GCP_PROJECT_ID=${{ secrets.EXPO_PUBLIC_GCP_PROJECT_ID }}" >> .env echo "$json" > google-services.json - name: 🏗️ EAS Build diff --git a/.github/workflows/build-submit-ios.yml b/.github/workflows/build-submit-ios.yml index f3759d0dd..6a46230ac 100644 --- a/.github/workflows/build-submit-ios.yml +++ b/.github/workflows/build-submit-ios.yml @@ -87,6 +87,7 @@ jobs: echo "EXPO_PUBLIC_BUNDLE_DATE=$(date -u +"%y%m%d%H")" >> .env echo "EXPO_PUBLIC_SENTRY_DSN=${{ secrets.SENTRY_DSN }}" >> .env echo "EXPO_PUBLIC_BITDRIFT_API_KEY=${{ secrets.BITDRIFT_API_KEY }}" >> .env + echo "EXPO_PUBLIC_GCP_PROJECT_ID=${{ secrets.EXPO_PUBLIC_GCP_PROJECT_ID }}" >> .env echo "${{ secrets.GOOGLE_SERVICES_TOKEN }}" > google-services.json - name: 🏗️ EAS Build diff --git a/.github/workflows/bundle-deploy-eas-update.yml b/.github/workflows/bundle-deploy-eas-update.yml index 1bd0b71c4..7c4fe9d76 100644 --- a/.github/workflows/bundle-deploy-eas-update.yml +++ b/.github/workflows/bundle-deploy-eas-update.yml @@ -116,6 +116,7 @@ jobs: echo "EXPO_PUBLIC_BUNDLE_DATE=$(date -u +"%y%m%d%H")" >> .env echo "EXPO_PUBLIC_SENTRY_DSN=${{ secrets.SENTRY_DSN }}" >> .env echo "EXPO_PUBLIC_BITDRIFT_API_KEY=${{ secrets.BITDRIFT_API_KEY }}" >> .env + echo "EXPO_PUBLIC_GCP_PROJECT_ID=${{ secrets.EXPO_PUBLIC_GCP_PROJECT_ID }}" >> .env echo "$json" > google-services.json - name: 🏗️ Create Bundle @@ -222,6 +223,7 @@ jobs: echo "EXPO_PUBLIC_BUNDLE_DATE=$(date -u +"%y%m%d%H")" >> .env echo "EXPO_PUBLIC_SENTRY_DSN=${{ secrets.SENTRY_DSN }}" >> .env echo "EXPO_PUBLIC_BITDRIFT_API_KEY=${{ secrets.BITDRIFT_API_KEY }}" >> .env + echo "EXPO_PUBLIC_GCP_PROJECT_ID=${{ secrets.EXPO_PUBLIC_GCP_PROJECT_ID }}" >> .env echo "${{ secrets.GOOGLE_SERVICES_TOKEN }}" > google-services.json - name: 🏗️ EAS Build @@ -313,6 +315,7 @@ jobs: echo "EXPO_PUBLIC_BUNDLE_DATE=$(date -u +"%y%m%d%H")" >> .env echo "EXPO_PUBLIC_SENTRY_DSN=${{ secrets.SENTRY_DSN }}" >> .env echo "EXPO_PUBLIC_BITDRIFT_API_KEY=${{ secrets.BITDRIFT_API_KEY }}" >> .env + echo "EXPO_PUBLIC_GCP_PROJECT_ID=${{ secrets.EXPO_PUBLIC_GCP_PROJECT_ID }}" >> .env echo "$json" > google-services.json - name: 🏗️ EAS Build diff --git a/.github/workflows/pull-request-comment.yml b/.github/workflows/pull-request-comment.yml index d04301002..7898bb963 100644 --- a/.github/workflows/pull-request-comment.yml +++ b/.github/workflows/pull-request-comment.yml @@ -165,6 +165,7 @@ jobs: echo "EXPO_PUBLIC_BUNDLE_DATE=$(date -u +"%y%m%d%H")" >> .env echo "EXPO_PUBLIC_SENTRY_DSN=${{ secrets.SENTRY_DSN }}" >> .env echo "EXPO_PUBLIC_BITDRIFT_API_KEY=${{ secrets.BITDRIFT_API_KEY }}" >> .env + echo "EXPO_PUBLIC_GCP_PROJECT_ID=${{ secrets.EXPO_PUBLIC_GCP_PROJECT_ID }}" >> .env echo "$json" > google-services.json - name: 🏗️ Create Bundle diff --git a/src/env/common.ts b/src/env/common.ts index dd2df7b17..fbf477726 100644 --- a/src/env/common.ts +++ b/src/env/common.ts @@ -80,8 +80,10 @@ export const BITDRIFT_API_KEY: string | undefined = process.env.EXPO_PUBLIC_BITDRIFT_API_KEY /** - * GCP project ID which is required for device attestation + * GCP project ID which is required for native device attestation. On web, this + * should be unset and evaluate to 0. */ -export const GCP_PROJECT_ID: number = Number( - process.env.EXPO_PUBLIC_GCP_PROJECT_ID, -) +export const GCP_PROJECT_ID: number = + process.env.EXPO_PUBLIC_GCP_PROJECT_ID === undefined + ? 0 + : Number(process.env.EXPO_PUBLIC_GCP_PROJECT_ID) -- cgit 1.4.1