From 08a83242906431acb06dde79467ec7dfdefa49f8 Mon Sep 17 00:00:00 2001 From: Eric Bailey Date: Thu, 7 Aug 2025 15:11:16 -0500 Subject: Fix e2e (#8794) * Only enable policy update overlay once the actual Overlay mounts (after onboarding and all that) * Disable policy overlay in e2e * Add comments * Add extra insurance * Rm log * Fix shared prefs test * Fix login flows by optionally closing 'Remember password' system dialog * Return missing testID * Bump dev-env --- __e2e__/flows/create-account.yml | 3 + __e2e__/flows/login.yml | 3 + package.json | 2 +- .../com/notifications/NotificationFeedItem.tsx | 20 ++-- src/view/com/testing/TestCtrls.e2e.tsx | 6 + src/view/screens/Storybook/index.tsx | 5 +- yarn.lock | 123 +++++++++++++-------- 7 files changed, 104 insertions(+), 58 deletions(-) diff --git a/__e2e__/flows/create-account.yml b/__e2e__/flows/create-account.yml index d03d3232f..4d49e9b6a 100644 --- a/__e2e__/flows/create-account.yml +++ b/__e2e__/flows/create-account.yml @@ -28,6 +28,9 @@ appId: xyz.blueskyweb.app - hideKeyboard - tapOn: id: "nextBtn" +- tapOn: + text: "Not Now" + optional: true - inputText: "e2e-test" - tapOn: id: "nextBtn" diff --git a/__e2e__/flows/login.yml b/__e2e__/flows/login.yml index 80e61a3ba..5ca40224c 100644 --- a/__e2e__/flows/login.yml +++ b/__e2e__/flows/login.yml @@ -23,4 +23,7 @@ appId: xyz.blueskyweb.app id: "loginPasswordInput" - inputText: "hunter2" - pressKey: Enter +- tapOn: + text: "Not Now" + optional: true - assertVisible: "Following" diff --git a/package.json b/package.json index cc06bcd96..dc8888860 100644 --- a/package.json +++ b/package.json @@ -220,7 +220,7 @@ "zod": "^3.20.2" }, "devDependencies": { - "@atproto/dev-env": "^0.3.155", + "@atproto/dev-env": "^0.3.160", "@babel/core": "^7.26.0", "@babel/preset-env": "^7.26.0", "@babel/runtime": "^7.26.0", diff --git a/src/view/com/notifications/NotificationFeedItem.tsx b/src/view/com/notifications/NotificationFeedItem.tsx index d5aba86f7..dc048bd26 100644 --- a/src/view/com/notifications/NotificationFeedItem.tsx +++ b/src/view/com/notifications/NotificationFeedItem.tsx @@ -195,16 +195,18 @@ let NotificationFeedItem = ({ } const isHighlighted = highlightUnread && !item.notification.isRead return ( - + + hideTopBorder={hideTopBorder} + /> + ) } diff --git a/src/view/com/testing/TestCtrls.e2e.tsx b/src/view/com/testing/TestCtrls.e2e.tsx index 5c8b21373..3273cf195 100644 --- a/src/view/com/testing/TestCtrls.e2e.tsx +++ b/src/view/com/testing/TestCtrls.e2e.tsx @@ -95,6 +95,12 @@ export function TestCtrls() { accessibilityRole="button" style={BTN} /> + navigate('Debug')} + accessibilityRole="button" + style={BTN} + /> queryClient.invalidateQueries({queryKey: ['post-feed']})} diff --git a/src/view/screens/Storybook/index.tsx b/src/view/screens/Storybook/index.tsx index 8285b0d73..870654761 100644 --- a/src/view/screens/Storybook/index.tsx +++ b/src/view/screens/Storybook/index.tsx @@ -87,9 +87,6 @@ function StorybookInner() { - - -