diff options
Diffstat (limited to 'src/view/com')
-rw-r--r-- | src/view/com/lists/ListItems.tsx | 8 | ||||
-rw-r--r-- | src/view/com/notifications/Feed.tsx | 8 | ||||
-rw-r--r-- | src/view/com/pager/PagerWithHeader.tsx | 29 | ||||
-rw-r--r-- | src/view/com/posts/Feed.tsx | 8 |
4 files changed, 33 insertions, 20 deletions
diff --git a/src/view/com/lists/ListItems.tsx b/src/view/com/lists/ListItems.tsx index 3658e5522..fe7b9b78a 100644 --- a/src/view/com/lists/ListItems.tsx +++ b/src/view/com/lists/ListItems.tsx @@ -19,9 +19,10 @@ import {useAnalytics} from 'lib/analytics/analytics' import {usePalette} from 'lib/hooks/usePalette' import {useWebMediaQueries} from 'lib/hooks/useWebMediaQueries' import {s} from 'lib/styles' -import {OnScrollCb} from 'lib/hooks/useOnMainScroll' +import {OnScrollHandler} from 'lib/hooks/useOnMainScroll' import {logger} from '#/logger' import {useModalControls} from '#/state/modals' +import {useAnimatedScrollHandler} from '#/lib/hooks/useAnimatedScrollHandler_FIXED' const LOADING_ITEM = {_reactKey: '__loading__'} const EMPTY_ITEM = {_reactKey: '__empty__'} @@ -44,7 +45,7 @@ export const ListItems = observer(function ListItemsImpl({ list: ListModel style?: StyleProp<ViewStyle> scrollElRef?: MutableRefObject<FlatList<any> | null> - onScroll?: OnScrollCb + onScroll: OnScrollHandler onPressTryAgain?: () => void renderHeader: () => JSX.Element renderEmptyState: () => JSX.Element @@ -205,6 +206,7 @@ export const ListItems = observer(function ListItemsImpl({ [list.isLoading], ) + const scrollHandler = useAnimatedScrollHandler(onScroll) return ( <View testID={testID} style={style}> <FlatList @@ -226,7 +228,7 @@ export const ListItems = observer(function ListItemsImpl({ } contentContainerStyle={s.contentContainer} style={{paddingTop: headerOffset}} - onScroll={onScroll} + onScroll={scrollHandler} onEndReached={onEndReached} onEndReachedThreshold={0.6} scrollEventThrottle={scrollEventThrottle} diff --git a/src/view/com/notifications/Feed.tsx b/src/view/com/notifications/Feed.tsx index dff84ec77..4794a9867 100644 --- a/src/view/com/notifications/Feed.tsx +++ b/src/view/com/notifications/Feed.tsx @@ -8,7 +8,8 @@ import {NotificationFeedLoadingPlaceholder} from '../util/LoadingPlaceholder' import {ErrorMessage} from '../util/error/ErrorMessage' import {LoadMoreRetryBtn} from '../util/LoadMoreRetryBtn' import {EmptyState} from '../util/EmptyState' -import {OnScrollCb} from 'lib/hooks/useOnMainScroll' +import {OnScrollHandler} from 'lib/hooks/useOnMainScroll' +import {useAnimatedScrollHandler} from '#/lib/hooks/useAnimatedScrollHandler_FIXED' import {s} from 'lib/styles' import {usePalette} from 'lib/hooks/usePalette' import {logger} from '#/logger' @@ -27,7 +28,7 @@ export const Feed = observer(function Feed({ view: NotificationsFeedModel scrollElRef?: MutableRefObject<FlatList<any> | null> onPressTryAgain?: () => void - onScroll?: OnScrollCb + onScroll?: OnScrollHandler ListHeaderComponent?: () => JSX.Element }) { const pal = usePalette('default') @@ -129,6 +130,7 @@ export const Feed = observer(function Feed({ [view], ) + const scrollHandler = useAnimatedScrollHandler(onScroll || {}) return ( <View style={s.hContentRegion}> <CenteredView> @@ -161,7 +163,7 @@ export const Feed = observer(function Feed({ } onEndReached={onEndReached} onEndReachedThreshold={0.6} - onScroll={onScroll} + onScroll={scrollHandler} scrollEventThrottle={1} contentContainerStyle={s.contentContainer} // @ts-ignore our .web version only -prf diff --git a/src/view/com/pager/PagerWithHeader.tsx b/src/view/com/pager/PagerWithHeader.tsx index f3ea4a1d1..8b9e0c85a 100644 --- a/src/view/com/pager/PagerWithHeader.tsx +++ b/src/view/com/pager/PagerWithHeader.tsx @@ -1,5 +1,10 @@ import * as React from 'react' -import {LayoutChangeEvent, StyleSheet, View} from 'react-native' +import { + LayoutChangeEvent, + NativeScrollEvent, + StyleSheet, + View, +} from 'react-native' import Animated, { Easing, useAnimatedReaction, @@ -11,14 +16,13 @@ import Animated, { import {Pager, PagerRef, RenderTabBarFnProps} from 'view/com/pager/Pager' import {TabBar} from './TabBar' import {useWebMediaQueries} from 'lib/hooks/useWebMediaQueries' -import {OnScrollCb} from 'lib/hooks/useOnMainScroll' -import {useAnimatedScrollHandler} from 'lib/hooks/useAnimatedScrollHandler_FIXED' +import {OnScrollHandler} from 'lib/hooks/useOnMainScroll' const SCROLLED_DOWN_LIMIT = 200 interface PagerWithHeaderChildParams { headerHeight: number - onScroll: OnScrollCb + onScroll: OnScrollHandler isScrolledDown: boolean } @@ -141,11 +145,10 @@ export const PagerWithHeader = React.forwardRef<PagerRef, PagerWithHeaderProps>( ) // props to pass into children render functions - const onScroll = useAnimatedScrollHandler({ - onScroll(e) { - scrollY.value = e.contentOffset.y - }, - }) + function onScrollWorklet(e: NativeScrollEvent) { + 'worklet' + scrollY.value = e.contentOffset.y + } const onPageSelectedInner = React.useCallback( (index: number) => { @@ -192,7 +195,9 @@ export const PagerWithHeader = React.forwardRef<PagerRef, PagerWithHeaderProps>( output = child({ headerHeight, isScrolledDown, - onScroll: i === currentPage ? onScroll : noop, + onScroll: { + onScroll: i === currentPage ? onScrollWorklet : noop, + }, }) } // Pager children must be noncollapsible plain <View>s. @@ -225,7 +230,9 @@ const styles = StyleSheet.create({ }, }) -function noop() {} +function noop() { + 'worklet' +} function toArray<T>(v: T | T[]): T[] { if (Array.isArray(v)) { diff --git a/src/view/com/posts/Feed.tsx b/src/view/com/posts/Feed.tsx index 1ecb14912..5b517f4c7 100644 --- a/src/view/com/posts/Feed.tsx +++ b/src/view/com/posts/Feed.tsx @@ -14,10 +14,11 @@ import {FeedErrorMessage} from './FeedErrorMessage' import {PostsFeedModel} from 'state/models/feeds/posts' import {FeedSlice} from './FeedSlice' import {LoadMoreRetryBtn} from '../util/LoadMoreRetryBtn' -import {OnScrollCb} from 'lib/hooks/useOnMainScroll' +import {OnScrollHandler} from 'lib/hooks/useOnMainScroll' import {s} from 'lib/styles' import {useAnalytics} from 'lib/analytics/analytics' import {usePalette} from 'lib/hooks/usePalette' +import {useAnimatedScrollHandler} from '#/lib/hooks/useAnimatedScrollHandler_FIXED' import {useTheme} from 'lib/ThemeContext' import {logger} from '#/logger' @@ -43,7 +44,7 @@ export const Feed = observer(function Feed({ feed: PostsFeedModel style?: StyleProp<ViewStyle> scrollElRef?: MutableRefObject<FlatList<any> | null> - onScroll?: OnScrollCb + onScroll?: OnScrollHandler scrollEventThrottle?: number renderEmptyState: () => JSX.Element renderEndOfFeed?: () => JSX.Element @@ -157,6 +158,7 @@ export const Feed = observer(function Feed({ [feed.isLoadingMore, feed.hasMore, feed.isEmpty, renderEndOfFeed], ) + const scrollHandler = useAnimatedScrollHandler(onScroll || {}) return ( <View testID={testID} style={style}> <FlatList @@ -178,7 +180,7 @@ export const Feed = observer(function Feed({ } contentContainerStyle={s.contentContainer} style={{paddingTop: headerOffset}} - onScroll={onScroll} + onScroll={onScroll != null ? scrollHandler : undefined} scrollEventThrottle={scrollEventThrottle} indicatorStyle={theme.colorScheme === 'dark' ? 'white' : 'black'} onEndReached={onEndReached} |