1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
|
#![warn(missing_docs)]
use crate::indieauth::User;
use async_trait::async_trait;
use serde::{Deserialize, Serialize};
//#[cfg(feature="redis")]
//mod redis;
//#[cfg(feature="redis")]
//pub use crate::database::redis::RedisStorage;
//#[cfg(all(redis, test))]
//pub use redis::tests::{get_redis_instance, RedisInstance};
mod file;
pub use crate::database::file::FileStorage;
/// Data structure representing a Micropub channel in the ?q=channels output.
#[derive(Serialize, Deserialize, PartialEq, Debug)]
pub struct MicropubChannel {
/// The channel's UID. It is usually also a publically accessible permalink URL.
pub uid: String,
/// The channel's user-friendly name used to recognize it in lists.
pub name: String,
}
/// Enum representing different errors that might occur during the database query.
#[derive(Debug, Clone, Copy)]
pub enum ErrorKind {
/// Backend error (e.g. database connection error)
Backend,
/// Error due to insufficient contextual permissions for the query
PermissionDenied,
/// Error due to the database being unable to parse JSON returned from the backing storage.
/// Usually indicative of someone fiddling with the database manually instead of using proper tools.
JsonParsing,
/// - ErrorKind::NotFound - equivalent to a 404 error. Note, some requests return an Option,
/// in which case None is also equivalent to a 404.
NotFound,
/// The user's query or request to the database was malformed. Used whenever the database processes
/// the user's query directly, such as when editing posts inside of the database (e.g. Redis backend)
BadRequest,
/// - ErrorKind::Other - when something so weird happens that it becomes undescribable.
Other,
}
/// Error signalled from the database.
#[derive(Debug)]
pub struct StorageError {
msg: String,
source: Option<Box<dyn std::error::Error + Send + Sync>>,
kind: ErrorKind,
}
impl From<StorageError> for tide::Response {
fn from(err: StorageError) -> Self {
tide::Response::builder(match err.kind() {
ErrorKind::BadRequest => 400,
ErrorKind::NotFound => 404,
_ => 500,
})
.body(serde_json::json!({
"error": match err.kind() {
ErrorKind::BadRequest => "invalid_request",
ErrorKind::NotFound => "not_found",
_ => "database_error"
},
"error_description": err
}))
.build()
}
}
impl std::error::Error for StorageError {
fn source(&self) -> Option<&(dyn std::error::Error + 'static)> {
self.source.as_ref().map(|e| e.as_ref() as &dyn std::error::Error)
}
}
impl From<serde_json::Error> for StorageError {
fn from(err: serde_json::Error) -> Self {
Self {
msg: format!("{}", err),
source: Some(Box::new(err)),
kind: ErrorKind::JsonParsing,
}
}
}
impl std::fmt::Display for StorageError {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
match match self.kind {
ErrorKind::Backend => write!(f, "backend error: "),
ErrorKind::JsonParsing => write!(f, "error while parsing JSON: "),
ErrorKind::PermissionDenied => write!(f, "permission denied: "),
ErrorKind::NotFound => write!(f, "not found: "),
ErrorKind::BadRequest => write!(f, "bad request: "),
ErrorKind::Other => write!(f, "generic storage layer error: "),
} {
Ok(_) => write!(f, "{}", self.msg),
Err(err) => Err(err),
}
}
}
impl serde::Serialize for StorageError {
fn serialize<S: serde::Serializer>(
&self,
serializer: S,
) -> std::result::Result<S::Ok, S::Error> {
serializer.serialize_str(&self.to_string())
}
}
impl StorageError {
/// Create a new StorageError of an ErrorKind with a message.
fn new(kind: ErrorKind, msg: &str) -> Self {
Self {
msg: msg.to_string(),
source: None,
kind,
}
}
/// Create a StorageError using another arbitrary Error as a source.
fn with_source(kind: ErrorKind, msg: &str, source: Box<dyn std::error::Error + Send + Sync>) -> Self {
Self {
msg: msg.to_string(),
source: Some(source),
kind
}
}
/// Get the kind of an error.
pub fn kind(&self) -> ErrorKind {
self.kind
}
/// Get the message as a string slice.
pub fn msg(&self) -> &str {
&self.msg
}
}
/// A special Result type for the Micropub backing storage.
pub type Result<T> = std::result::Result<T, StorageError>;
pub fn filter_post(mut post: serde_json::Value, user: &'_ Option<String>) -> Option<serde_json::Value> {
if post["properties"]["deleted"][0].is_string() {
return Some(serde_json::json!({
"type": post["type"],
"properties": {
"deleted": post["properties"]["deleted"]
}
}));
}
let empty_vec: Vec<serde_json::Value> = vec![];
let author = post["properties"]["author"]
.as_array()
.unwrap_or(&empty_vec)
.iter()
.map(|i| i.as_str().unwrap().to_string());
let visibility = post["properties"]["visibility"][0]
.as_str()
.unwrap_or("public");
let mut audience = author.chain(
post["properties"]["audience"]
.as_array()
.unwrap_or(&empty_vec)
.iter()
.map(|i| i.as_str().unwrap().to_string()),
);
if (visibility == "private" && !audience.any(|i| Some(i) == *user))
|| (visibility == "protected" && user.is_none())
{
return None;
}
if post["properties"]["location"].is_array() {
let location_visibility = post["properties"]["location-visibility"][0]
.as_str()
.unwrap_or("private");
let mut author = post["properties"]["author"]
.as_array()
.unwrap_or(&empty_vec)
.iter()
.map(|i| i.as_str().unwrap().to_string());
if location_visibility == "private" && !author.any(|i| Some(i) == *user) {
post["properties"]
.as_object_mut()
.unwrap()
.remove("location");
}
}
Some(post)
}
/// A storage backend for the Micropub server.
///
/// Implementations should note that all methods listed on this trait MUST be fully atomic
/// or lock the database so that write conflicts or reading half-written data should not occur.
#[async_trait]
pub trait Storage: Clone + Send + Sync {
/// Check if a post exists in the database.
async fn post_exists(&self, url: &str) -> Result<bool>;
/// Load a post from the database in MF2-JSON format, deserialized from JSON.
async fn get_post(&self, url: &str) -> Result<Option<serde_json::Value>>;
/// Save a post to the database as an MF2-JSON structure.
///
/// Note that the `post` object MUST have `post["properties"]["uid"][0]` defined.
async fn put_post<'a>(&self, post: &'a serde_json::Value, user: &'a str) -> Result<()>;
/// Modify a post using an update object as defined in the Micropub spec.
///
/// Note to implementors: the update operation MUST be atomic OR MUST lock the database
/// to prevent two clients overwriting each other's changes.
///
/// You can assume concurrent updates will never contradict each other, since that will be dumb.
/// The last update always wins.
async fn update_post<'a>(&self, url: &'a str, update: serde_json::Value) -> Result<()>;
/// Get a list of channels available for the user represented by the URL `user` to write to.
async fn get_channels<'a>(&self, user: &'a str) -> Result<Vec<MicropubChannel>>;
/// Fetch a feed at `url` and return a an h-feed object containing
/// `limit` posts after a post by url `after`, filtering the content
/// in context of a user specified by `user` (or an anonymous user).
///
/// Specifically, private posts that don't include the user in the audience
/// will be elided from the feed, and the posts containing location and not
/// specifying post["properties"]["location-visibility"][0] == "public"
/// will have their location data (but not check-in data) stripped.
///
/// This function is used as an optimization so the client, whatever it is,
/// doesn't have to fetch posts, then realize some of them are private, and
/// fetch more posts.
///
/// Note for implementors: if you use streams to fetch posts in parallel
/// from the database, preferably make this method use a connection pool
/// to reduce overhead of creating a database connection per post for
/// parallel fetching.
async fn read_feed_with_limit<'a>(
&self,
url: &'a str,
after: &'a Option<String>,
limit: usize,
user: &'a Option<String>,
) -> Result<Option<serde_json::Value>>;
/// Deletes a post from the database irreversibly. 'nuff said. Must be idempotent.
async fn delete_post<'a>(&self, url: &'a str) -> Result<()>;
/// Gets a setting from the setting store and passes the result.
async fn get_setting<'a>(&self, setting: &'a str, user: &'a str) -> Result<String>;
/// Commits a setting to the setting store.
async fn set_setting<'a>(&self, setting: &'a str, user: &'a str, value: &'a str) -> Result<()>;
}
#[cfg(test)]
mod tests {
//#[cfg(feature="redis")]
//use super::redis::tests::get_redis_instance;
use super::{MicropubChannel, Storage};
use serde_json::json;
use paste::paste;
async fn test_backend_basic_operations<Backend: Storage>(backend: Backend) {
let post: serde_json::Value = json!({
"type": ["h-entry"],
"properties": {
"content": ["Test content"],
"author": ["https://fireburn.ru/"],
"uid": ["https://fireburn.ru/posts/hello"],
"url": ["https://fireburn.ru/posts/hello", "https://fireburn.ru/posts/test"]
}
});
let key = post["properties"]["uid"][0].as_str().unwrap().to_string();
let alt_url = post["properties"]["url"][1].as_str().unwrap().to_string();
// Reading and writing
backend
.put_post(&post, "https://fireburn.ru/")
.await
.unwrap();
if let Some(returned_post) = backend.get_post(&key).await.unwrap() {
assert!(returned_post.is_object());
assert_eq!(
returned_post["type"].as_array().unwrap().len(),
post["type"].as_array().unwrap().len()
);
assert_eq!(
returned_post["type"].as_array().unwrap(),
post["type"].as_array().unwrap()
);
let props: &serde_json::Map<String, serde_json::Value> =
post["properties"].as_object().unwrap();
for key in props.keys() {
assert_eq!(
returned_post["properties"][key].as_array().unwrap(),
post["properties"][key].as_array().unwrap()
)
}
} else {
panic!("For some reason the backend did not return the post.")
}
// Check the alternative URL - it should return the same post
if let Ok(Some(returned_post)) = backend.get_post(&alt_url).await {
assert!(returned_post.is_object());
assert_eq!(
returned_post["type"].as_array().unwrap().len(),
post["type"].as_array().unwrap().len()
);
assert_eq!(
returned_post["type"].as_array().unwrap(),
post["type"].as_array().unwrap()
);
let props: &serde_json::Map<String, serde_json::Value> =
post["properties"].as_object().unwrap();
for key in props.keys() {
assert_eq!(
returned_post["properties"][key].as_array().unwrap(),
post["properties"][key].as_array().unwrap()
)
}
} else {
panic!("For some reason the backend did not return the post.")
}
}
/// Note: this is merely a smoke check and is in no way comprehensive.
async fn test_backend_update<Backend: Storage>(backend: Backend) {
let post: serde_json::Value = json!({
"type": ["h-entry"],
"properties": {
"content": ["Test content"],
"author": ["https://fireburn.ru/"],
"uid": ["https://fireburn.ru/posts/hello"],
"url": ["https://fireburn.ru/posts/hello", "https://fireburn.ru/posts/test"]
}
});
let key = post["properties"]["uid"][0].as_str().unwrap().to_string();
// Reading and writing
backend
.put_post(&post, "https://fireburn.ru/")
.await
.unwrap();
backend.update_post(&key, json!({
"url": &key,
"add": {
"category": ["testing"],
},
"replace": {
"content": ["Different test content"]
}
})).await.unwrap();
if let Some(returned_post) = backend.get_post(&key).await.unwrap() {
assert!(returned_post.is_object());
assert_eq!(
returned_post["type"].as_array().unwrap().len(),
post["type"].as_array().unwrap().len()
);
assert_eq!(
returned_post["type"].as_array().unwrap(),
post["type"].as_array().unwrap()
);
assert_eq!(
returned_post["properties"]["content"][0].as_str().unwrap(),
"Different test content"
);
assert_eq!(
returned_post["properties"]["category"].as_array().unwrap(),
&vec![json!("testing")]
);
} else {
panic!("For some reason the backend did not return the post.")
}
}
async fn test_backend_get_channel_list<Backend: Storage>(backend: Backend) {
let feed = json!({
"type": ["h-feed"],
"properties": {
"name": ["Main Page"],
"author": ["https://fireburn.ru/"],
"uid": ["https://fireburn.ru/feeds/main"]
},
"children": []
});
backend
.put_post(&feed, "https://fireburn.ru/")
.await
.unwrap();
let chans = backend
.get_channels("https://fireburn.ru/")
.await
.unwrap();
assert_eq!(chans.len(), 1);
assert_eq!(
chans[0],
MicropubChannel {
uid: "https://fireburn.ru/feeds/main".to_string(),
name: "Main Page".to_string()
}
);
}
async fn test_backend_settings<Backend: Storage>(backend: Backend) {
backend
.set_setting("site_name", "https://fireburn.ru/", "Vika's Hideout")
.await
.unwrap();
assert_eq!(
backend
.get_setting("site_name", "https://fireburn.ru/")
.await
.unwrap(),
"Vika's Hideout"
);
}
/*macro_rules! redis_test {
($func_name:expr) => {
paste! {
#[cfg(feature="redis")]
#[async_std::test]
async fn [<redis_ $func_name>] () {
test_logger::ensure_env_logger_initialized();
let redis_instance = get_redis_instance().await;
let backend = super::RedisStorage::new(redis_instance.uri().to_string())
.await
.unwrap();
$func_name(backend).await
}
}
}
}*/
macro_rules! file_test {
($func_name:expr) => {
paste! {
#[async_std::test]
async fn [<file_ $func_name>] () {
test_logger::ensure_env_logger_initialized();
let tempdir = tempdir::TempDir::new("file").expect("Failed to create tempdir");
let backend = super::FileStorage::new(tempdir.into_path()).await.unwrap();
$func_name(backend).await
}
}
}
}
/*redis_test!(test_backend_basic_operations);
redis_test!(test_backend_get_channel_list);
redis_test!(test_backend_settings);
redis_test!(test_backend_update);*/
file_test!(test_backend_basic_operations);
file_test!(test_backend_get_channel_list);
file_test!(test_backend_settings);
file_test!(test_backend_update);
}
|